[Mesa-dev] [PATCH 3/3] panfrost: Add support for modifiers

[Daniel Stone]

Hi,

On Thu, 4 Jul 2019 at 09:47, Tomeu Vizoso <tomeu.vizoso at collabora.com> wrote:
> On Thu, 4 Jul 2019 at 10:05, Tomeu Vizoso <tomeu.vizoso at collabora.com> wrote:
> > -        pres->layout = should_tile ? PAN_TILED : PAN_LINEAR;
> > +       if (want_afbc || (is_renderable && can_afbc && !is_texture))
> > +                pres->layout = PAN_AFBC;
>
> We regress here because we seem to have some bugs regarding AFBC usage
> with some formats such as rgba4 and rgb5_a1:
>
> https://gitlab.freedesktop.org/tomeu/mesa/-/jobs/399237
>
> I'm looking at only enabling AFBC when explicitly asked to by the winsys.

Again, the winsys just pulls the list of acceptable format/modifier
pairs from the EGL format query. If Panfrost declares 1555+AFBC to be
a supported combination, then the winsys will pass that on for clients
to use. If it isn't working, my suggestion is to just never advertise
it in the first place.

Cheers,
Daniel