[Mesa-dev] [PATCH 1/3] panfrost: Move ra_regs to the screen context

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Thu Jun 20 13:32:22 UTC 2019


Oh, this looks lovely! Thank you!

One concern I have is that we're leaking work_vec* for
REGS_VARIANTS_COUNT-1 variants, since we reinitialize those classes for
each RA variant (I believe that is correct behaviour) but only store the
last one (I believe that is incorrect).

Perhaps we should make those [REGS_VARIANTS_COUNT] arrays, too?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190620/8af14b05/attachment.sig>


More information about the mesa-dev mailing list