[Mesa-dev] [PATCH 2/4] glsl: init non-static class member in link uniforms.

Dave Airlie airlied at gmail.com
Fri May 17 02:22:22 UTC 2019


From: Dave Airlie <airlied at redhat.com>

link_uniforms.cpp:477: uninit_member: Non-static class member "shader_storage_blocks_write_access" is not initialized in this constructor nor in any functions that it calls.

Reported by coverity.
---
 src/compiler/glsl/link_uniforms.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp
index aa96227a7e1..641d38689bf 100644
--- a/src/compiler/glsl/link_uniforms.cpp
+++ b/src/compiler/glsl/link_uniforms.cpp
@@ -472,7 +472,8 @@ public:
                               bool use_std430_as_default)
       : prog(prog), map(map), uniforms(uniforms),
         use_std430_as_default(use_std430_as_default), values(values),
-        bindless_targets(NULL), bindless_access(NULL)
+        bindless_targets(NULL), bindless_access(NULL),
+        shader_storage_blocks_write_access(9)
    {
    }
 
-- 
2.21.0



More information about the mesa-dev mailing list