You've actually fixed a much more important compiler bug than you might think. The 0.5 swizzle is really being used even without constant folding, specifically in reducing the number of shader immediates (r300_tgsi_to_rc.c : handle_immediate) Thanks. All Nicolai's compiler work in his repo is now merged to master. -Marek <div class="gmail_quote">On Tue, May 18, 2010 at 9:03 AM, Tom Stellard <<a href="mailto:tstellar@gmail.com" target="_blank">tstellar@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Attached is a patch to fix constant folding in the r300 compiler implemented in commit c704933 of Nicolai's r300g-glsl branch (git://<a href="http://anongit.freedesktop.org/%7Enh/mesa" target="_blank">anongit.freedesktop.org/~nh/mesa</a>). With this patch, the constant folding implementation can be cherry-picked to master without breaking any piglit tests. -Tom _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div>