<div class="gmail_quote">On Tue, May 25, 2010 at 9:51 AM, Jerome Glisse <span dir="ltr"><<a href="mailto:glisse@freedesktop.org">glisse@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="im">On Tue, May 25, 2010 at 12:35:45AM +0200, Bas Nieuwenhuizen wrote:<br> > Hello,<br> ><br> > I wrote two patches that fix various things to get r600g running on my<br> > computer and to get r600_clear and depthtesting working.<br> ><br> > I wrote them starting from Marek's r600g branch.<br> ><br> > Feel free to criticize as this is my first contribution to a large<br> > project.<br> ><br> > - Bas Nieuwenhuizen<br> ><br> > patches:<br> > <a href="http://www.basnieuwenhuizen.nl/0001-r600g-various-fixes.patch" target="_blank">http://www.basnieuwenhuizen.nl/0001-r600g-various-fixes.patch</a><br> <br> </div>I don't think change to r600_texture_destroy is right, why did you<br> remove the unreference there ?<br></blockquote><div><br>pipe_resource_reference calls resource_destroy (that is r600_texture_destroy here) if the reference counter is zero. Using pipe_resource_reference in the destroy function itself seems rather pointless and I think it's even undefined.<br> </div></div><br>-Marek<br>