The patch looks good but it's r5xx-only. I'll commit this when an r3xx version is implemented too. -Marek <div class="gmail_quote">On Mon, May 24, 2010 at 6:00 PM, Gianluca Anzolin <<a href="mailto:gianluca@sottospazio.it">gianluca@sottospazio.it</a>> wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hello, Yesterday I was trying to run an example taken from chapter 6 of the book OpenGl Shading Language with the new gallium driver (I have a RV570 graphic card), but I got this error when compiling the vertex shader: Unknown opcode 35. Digging in the source code I found that the opcode 35 is for the > operator between two vectors (RC_OPCODE_SGT). It's related to the following vertex shader code: if (diffuse > 0.0) { spec = max(dot(reflectVec, viewVec), 0.0); spec = pow(spec, 16.0); } When I changed the comparison to ">=" the problem disappeared. Infact there is no switch case for RC_OPCODE_SGT in the file r3xx_vertprog.c. I added that case to the switch statement (see the patch attached) and I got it working even with the ">" operator. I hope the patch is correct, if there is a better fix I'd really like to know. Thanks, Gianluca _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div>