<div class="gmail_quote">On Sun, Jun 6, 2010 at 10:53 AM, Tom Stellard <<a href="mailto:tstellar@gmail.com">tstellar@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Hi, I have just published a branch with loop emulation for the r300 compiler here: <a href="http://cgit.freedesktop.org/%7Etstellar/mesa/" target="_blank">http://cgit.freedesktop.org/~tstellar/mesa/</a> This adds support for unrolling of loops that have a constant number of iterations (e.g. for(i=0; i<10; i++) or for(i=10; i>0; i--) It only handles cases where the counter is either added to or subtracted from, like the examples above, but I think this covers a majority of loops. Loops that have an unknown number of iterations are unrolled as many times as possible without going over the instruction limit for the shader program. </blockquote></div> If you're expecting e.g. ENDIF, please check whether the instruction is really there. Also, unrolling loops until the instruction limit is reached seems rather itchy, but still better than my idea of loading dummy shaders. ;) I haven't reviewed the commits line by line, but generally it looks good, thanks. If it passes enough tests, I'll be happy to push it. -Marek PS: BTW piglit/glsl-fs-loop-const-incr passes even without loop emulation. The simplest loops seem to be unrolled by the GLSL compiler. The "decr" test does need the loop emulation though.