<div class="gmail_quote">On Tue, Jul 20, 2010 at 4:08 PM, Brian Paul <span dir="ltr"><<a href="mailto:brianp@vmware.com">brianp@vmware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div></div><div class="h5">On 07/19/2010 02:53 PM, Marek Olšák wrote:<br></div></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">@@ -150,7 +200,10 @@ update_textures(struct st_context *st)<br>
<br>
/* if sampler view has changed dereference it */<br>
if (stObj->sampler_view)<br>
- if (check_sampler_swizzle(stObj->sampler_view, stObj->base._Swizzle) || (st_view_format != stObj->sampler_view->format))<br>
</blockquote>
<br>
Please break that long line into two sub-80-column lines.<br></blockquote><div><br>Please note the "-" sign, i.e. the line is removed in the patch.<br><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
+ if (check_sampler_swizzle(stObj->sampler_view,<br>
+ stObj->base._Swizzle,<br>
+ stObj->base.DepthMode) ||<br>
+ (st_view_format != stObj->sampler_view->format))<br>
pipe_sampler_view_reference(&stObj->sampler_view, NULL);<br>
<br>
sampler_view = st_get_texture_sampler_view_from_stobj(stObj, pipe, st_view_format);<br>
--<br>
</blockquote>
<br>
<br>
Have you tested with all the piglit depth-tex-modes tests? You should probably run all the piglit texture tests for that matter.<br></blockquote><div><br>Yes, I have tested all the piglit tests including the depth-tex-mode ones, which now pass. There is the updated patch attached, which has all your remarks fixed.<br>
<br>-Marek<br></div></div>