<div class="gmail_quote">On Mon, Aug 16, 2010 at 2:37 AM, nobled <<a href="mailto:nobled@dreamwidth.org">nobled@dreamwidth.org</a>> wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Except for the first patch, this is mostly adding a bunch of different null checks: 1. r300g: Fix macro This fixes a potential bug if (has_hyperz) is false (it would act as if has_hyperz is true). 2. r300g: Fix leaks in failed context creation This patch is the biggest one: It refactors the create/destroy context functions; before, if r300_create_context failed to allocate something essential it was either ignored or it only partly cleaned up after itself (ex: leaking all the allocations in r300_init_atoms(), forgetting to decrement the number of existing contexts, leaking the mutexes initialized by r300_hyperz_init_mm, etc), and there's a *lot* to stuff to clean up, so this just re-uses the logic in r300_destroy_context to avoid code duplication. 3. r300g: Let hyperz init fail Adds a boolean return value to check if the calls to u_mmInit failed (they can potentially return null) </blockquote><div> Pushed, thanks! </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> 4. gallium: Check if draw_create returns null This changes all the drivers that depend on the draw module to abort if draw_create returned null (which it might if using LLVM and on a CPU without SSE2, or if it just couldn't allocate memory) </blockquote><div> The r300g part is ok. Concerning the rest, I'd like to get a consent from the other driver maintainers. </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> 5. draw: Check if llvm returns null Always check for null and don't rely on assert(), since that won't help on non-debug builds. Might also help with <a href="http://bugs.freedesktop.org/29578" target="_blank">http://bugs.freedesktop.org/29578</a> . </blockquote><div> I think we should fall back to the non-LLVM path i.e. the slow, interpreted one. Luca has also sent an alternate fix: <a href="http://lists.freedesktop.org/archives/mesa-dev/2010-August/002124.html">http://lists.freedesktop.org/archives/mesa-dev/2010-August/002124.html</a> </div></div> -Marek