Please could we get this feature committed to master? I'd like to close Bug 31827.<br><br>Thank you.<br><br>Marek<br><br><div class="gmail_quote">On Thu, Nov 25, 2010 at 6:49 PM, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">On Thursday 25 November 2010 06:55:54 you wrote:<br> > I am ok with either solution as long as it fixes *Bug<br> </div>> 31827*<<a href="https://bugs.freedesktop.org/show_bug.cgi?id=31827" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=31827</a>><br> <div class="im">> .<br> ><br> > I have tested my patch and it works. There was a bug in lower_jumps that<br> > made discard statements with a condition be treated as without it, causing<br> > the removal of all instructions after discard. This code from my patch<br> > fixes it:<br> <br> </div>Good call - that's definitely broken. 狢 suppose we never hit it before because<br> we never generated conditional discards.<br> <br> I'm tempted to simply remove discard from lower_jumps - the other two passes<br> should handle it.<br> <div><div></div><div class="h5">_______________________________________________<br> mesa-dev mailing list<br> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br> </div></div></blockquote></div><br>