<div class="gmail_quote">On Wed, Mar 30, 2011 at 2:45 PM, Keith Whitwell <span dir="ltr"><<a href="mailto:keithw@vmware.com" target="_blank">keithw@vmware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div><div></div><div>> diff --git a/src/gallium/auxiliary/draw/draw_llvm.h b/src/gallium/auxiliary/draw/draw_llvm.h<br> > index e8623e7..643a9ef 100644<br> > --- a/src/gallium/auxiliary/draw/draw_llvm.h<br> > +++ b/src/gallium/auxiliary/draw/draw_llvm.h<br> > @@ -162,6 +162,7 @@ struct draw_llvm_variant_key<br> > {<br> > unsigned nr_vertex_elements:8;<br> > unsigned nr_samplers:8;<br> > + unsigned clamp_vertex_color:8;<br> > unsigned clip_xy:1;<br> > unsigned clip_z:1;<br> > unsigned clip_user:1;<br> <br> </div></div>Why are there 8 bits for this?<br> <br> I'd suggest 1 bit is sufficient, and that you should take one bit from<br> "pad" to make space for it.<br></blockquote><div><br>It seems to be a typo. I have now fixed it, this is the updated part of the patch:<br><br>diff --git a/src/gallium/auxiliary/draw/draw_llvm.h b/src/gallium/auxiliary/draw/draw_llv<br> index e8623e7..873a272 100644<br> --- a/src/gallium/auxiliary/draw/draw_llvm.h<br>+++ b/src/gallium/auxiliary/draw/draw_llvm.h<br>@@ -162,6 +162,7 @@ struct draw_llvm_variant_key<br> {<br> unsigned nr_vertex_elements:8;<br> unsigned nr_samplers:8;<br> + unsigned clamp_vertex_color:1;<br> unsigned clip_xy:1;<br> unsigned clip_z:1;<br> unsigned clip_user:1;<br>@@ -169,7 +170,7 @@ struct draw_llvm_variant_key<br> unsigned bypass_viewport:1;<br> unsigned need_edgeflags:1;<br> unsigned nr_planes:4;<br>- unsigned pad:6;<br>+ unsigned pad:5;<br> <br> /* Variable number of vertex elements:<br> */<br><br><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div><div><br> </div></div>Otherwise, it looks good to me.<br></blockquote><div><br>OK.<br><br>Marek <br></div></div><br>