Pushed, thanks.<br><br>Marek<br><br><div class="gmail_quote">On Sat, Apr 16, 2011 at 10:15 PM, Marcin Slusarz <span dir="ltr"><<a href="mailto:marcin.slusarz@gmail.com" target="_blank">marcin.slusarz@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Without it gcc complains:<br>
nv50_screen.c: In function ‘nv50_screen_is_format_supported’:<br>
nv50_screen.c:48: warning: implicit declaration of function ‘util_format_is_supported’<br>
<br>
and handles it wrongly - util_format_is_supported returns boolean, which is typedef'ed<br>
to uchar, but function without prototype is assumed to return int.<br>
<br>
For me nv50_screen_is_format_supported was returning true for float formats without<br>
--enable-texture-float...<br>
---<br>
src/gallium/drivers/i915/i915_screen.c | 1 +<br>
src/gallium/drivers/i965/brw_screen.c | 1 +<br>
src/gallium/drivers/nv50/nv50_screen.c | 1 +<br>
src/gallium/drivers/nvc0/nvc0_screen.c | 1 +<br>
src/gallium/drivers/nvfx/nvfx_screen.c | 1 +<br>
src/gallium/drivers/r600/r600_pipe.c | 1 +<br>
6 files changed, 6 insertions(+), 0 deletions(-)<br>
<br>
diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c<br>
index 6f6a342..0f4327f 100644<br>
--- a/src/gallium/drivers/i915/i915_screen.c<br>
+++ b/src/gallium/drivers/i915/i915_screen.c<br>
@@ -27,6 +27,7 @@<br>
<br>
<br>
#include "draw/draw_context.h"<br>
+#include "util/u_format.h"<br>
#include "util/u_inlines.h"<br>
#include "util/u_memory.h"<br>
#include "util/u_string.h"<br>
diff --git a/src/gallium/drivers/i965/brw_screen.c b/src/gallium/drivers/i965/brw_screen.c<br>
index 5353ae2..9178dfa 100644<br>
--- a/src/gallium/drivers/i965/brw_screen.c<br>
+++ b/src/gallium/drivers/i965/brw_screen.c<br>
@@ -26,6 +26,7 @@<br>
**************************************************************************/<br>
<br>
<br>
+#include "util/u_format.h"<br>
#include "util/u_inlines.h"<br>
#include "util/u_memory.h"<br>
#include "util/u_string.h"<br>
diff --git a/src/gallium/drivers/nv50/nv50_screen.c b/src/gallium/drivers/nv50/nv50_screen.c<br>
index e0eea3e..641ad7e 100644<br>
--- a/src/gallium/drivers/nv50/nv50_screen.c<br>
+++ b/src/gallium/drivers/nv50/nv50_screen.c<br>
@@ -20,6 +20,7 @@<br>
* SOFTWARE.<br>
*/<br>
<br>
+#include "util/u_format.h"<br>
#include "util/u_format_s3tc.h"<br>
#include "pipe/p_screen.h"<br>
<br>
diff --git a/src/gallium/drivers/nvc0/nvc0_screen.c b/src/gallium/drivers/nvc0/nvc0_screen.c<br>
index c4cdfac..5325807 100644<br>
--- a/src/gallium/drivers/nvc0/nvc0_screen.c<br>
+++ b/src/gallium/drivers/nvc0/nvc0_screen.c<br>
@@ -20,6 +20,7 @@<br>
* SOFTWARE.<br>
*/<br>
<br>
+#include "util/u_format.h"<br>
#include "util/u_format_s3tc.h"<br>
#include "pipe/p_screen.h"<br>
<br>
diff --git a/src/gallium/drivers/nvfx/nvfx_screen.c b/src/gallium/drivers/nvfx/nvfx_screen.c<br>
index abbed96..ab063d6 100644<br>
--- a/src/gallium/drivers/nvfx/nvfx_screen.c<br>
+++ b/src/gallium/drivers/nvfx/nvfx_screen.c<br>
@@ -1,5 +1,6 @@<br>
#include "pipe/p_screen.h"<br>
#include "pipe/p_state.h"<br>
+#include "util/u_format.h"<br>
#include "util/u_format_s3tc.h"<br>
#include "util/u_simple_screen.h"<br>
<br>
diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c<br>
index 066768f..1a581c7 100644<br>
--- a/src/gallium/drivers/r600/r600_pipe.c<br>
+++ b/src/gallium/drivers/r600/r600_pipe.c<br>
@@ -30,6 +30,7 @@<br>
#include <tgsi/tgsi_util.h><br>
#include <util/u_blitter.h><br>
#include <util/u_double_list.h><br>
+#include "util/u_format.h"<br>
#include <util/u_format_s3tc.h><br>
#include <util/u_transfer.h><br>
#include <util/u_surface.h><br>
<font color="#888888">--<br>
1.7.4.1<br>
<br>
</font></blockquote></div><br>