<div class="gmail_quote">On Tue, Apr 26, 2011 at 4:57 PM, Brian Paul <span dir="ltr"><<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On 04/26/2011 04:57 AM, Marek Olšák wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
this series implements GL_EXT_texture_shared_exponent.<br>
<br>
The file rgb9e5.h has all its functions inline, because it's shared<br>
between classic and gallium. In that file, there are functions<br>
rgb9e5_to_float3 and float3_to_rgb9e5, which are used pretty much<br>
everywhere.<br>
</blockquote>
<br></div>
I think I'd opt to put the code for this in gallium/util and include it in Mesa with a wrapper header. In the future I think we're more likely to use additional Gallium utility code in Mesa than vice versa.</blockquote>
<div><br>Will do.<br><br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex"><div><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I usually do some hardware support and the driver of my choice was<br>
so far r300g. Because r500 hw can't do this extension, I am adding<br>
support to r600g instead.<br>
<br>
There is swrast, softpipe, llvmpipe, and r600g support. There is no<br>
renderbuffer support, because r600 can't do it and the spec doesn't<br>
require it anyway. (I guess it wasn't meant to be used as a<br>
renderbuffer)<br>
<br>
Please review.<br>
</blockquote>
<br></div>
Reviewed-by: Brian Paul <<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>><br>
<br>
Were you going to make a piglit test too?<br></blockquote><div><br>There are these tests:<br>./fbo-generatemipmap-formats GL_EXT_texture_shared_exponent<br>./texwrap GL_RGB9_E5<br><br>And yesterday I updated glean/pixelFormats to test this extension as well.<br>
<br>Marek<br></div></div>