<br><br><div class="gmail_quote">On Mon, Jul 18, 2011 at 07:31, Fredrik Höglund <span dir="ltr"><<a href="mailto:fredrik@kde.org">fredrik@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> Commit 1a339b6c71ebab6e1a64f05b2e133022d3bbcd15 made<br> st_ChooseTextureFormat map GL_RGBA with type GL_UNSIGNED_BYTE<br> to PIPE_FORMAT_A8B8G8R8_UNORM.<br> <br> The image format for ARGB pixmaps is PIPE_FORMAT_B8G8R8A8_UNORM<br> however. This mismatch caused the texture to be recreated in<br> st_finalize_texture.<br> <br> NOTE: This is a candidate for the 7.11 branch.<br> <br></blockquote><div>Yes very much so.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=39209" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=39209</a><br> Signed-off-by: Fredrik Höglund <<a href="mailto:fredrik@kde.org">fredrik@kde.org</a>><br></blockquote><div><br></div><div>Reviewed-by: Stéphane Marchesin <<a href="mailto:marcheu@chromium.org">marcheu@chromium.org</a>></div> <div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> ---<br> src/mesa/state_tracker/st_manager.c | 2 +-<br> 1 files changed, 1 insertions(+), 1 deletions(-)<br> <br> diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c<br> index 7bd82aa..d5228d3 100644<br> --- a/src/mesa/state_tracker/st_manager.c<br> +++ b/src/mesa/state_tracker/st_manager.c<br> @@ -587,7 +587,7 @@ st_context_teximage(struct st_context_iface *stctxi,<br> internalFormat = GL_RGB;<br> <br> texFormat = st_ChooseTextureFormat(ctx, internalFormat,<br> - GL_RGBA, GL_UNSIGNED_BYTE);<br> + GL_BGRA, GL_UNSIGNED_BYTE);<br> <br> _mesa_init_teximage_fields(ctx, target, texImage,<br> tex->width0, tex->height0, 1, 0,<br> <font color="#888888">--<br> 1.7.6<br> <br> _______________________________________________<br> mesa-dev mailing list<br> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br> </font></blockquote></div><br>