<div class="gmail_quote">On Fri, Sep 2, 2011 at 15:53, Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> <div class="im">On Fri, 2 Sep 2011 12:33:44 -0300, Eugeni Dodonov <<a href="mailto:eugeni@dodonov.net">eugeni@dodonov.net</a>> wrote: > From: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com">eugeni.dodonov@intel.com</a>> > > This could happen in 3 different cases, and ERRNO can explain what > happened. First case would be EIO (gpu hang), second EINVAL (something is > wrong inside the batch), and we also discovered that sometimes it happens > with ENOSPACE. All of those cases are different it it could be worth to at > least know what happened. > > Signed-off-by: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com">eugeni.dodonov@intel.com</a>> > --- > src/mesa/drivers/dri/intel/intel_batchbuffer.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/mesa/drivers/dri/intel/intel_batchbuffer.c b/src/mesa/drivers/dri/intel/intel_batchbuffer.c > index db4343b..73367f3 100644 > --- a/src/mesa/drivers/dri/intel/intel_batchbuffer.c > +++ b/src/mesa/drivers/dri/intel/intel_batchbuffer.c > @@ -138,6 +138,7 @@ do_flush_locked(struct intel_context *intel) > } > > if (ret != 0) { > + _mesa_warning(NULL, "do_flush_locked: %d\n", ret); > exit(1); > } > intel->vtbl.new_batch(intel); </div>I would make it fprintf(stderr, "intel_batchbuffer_flush failed: %s\n", strerror(ret)); You want the output even if built without Mesa debugging enabled, and strings are nicer than numbers. </blockquote></div> Indeed, thanks for the idea! -- Eugeni Dodonov <a href="http://eugeni.dodonov.net/" target="_blank">http://eugeni.dodonov.net/</a>