<div class="gmail_quote">On 5 September 2011 14:25, Eric Anholt <span dir="ltr"><<a href="mailto:eric@anholt.net">eric@anholt.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
On Fri, 2 Sep 2011 21:21:10 -0700, Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> wrote:<br>
Non-text part: multipart/alternative<br>
<div class="im">> On 2 September 2011 18:37, Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a>> wrote:<br>
><br>
> > This series gets gen4 to be non-regressing for the new vertex shader.<br>
> > I'd be fine with not pushing the last patch and letting Paul's patches<br>
> > land, then fixing the bug as it remains there. Once these two land, I<br>
> > think it's time to turn on the new backend by default.<br>
> ><br>
><br>
> This plan sounds good to me. I'd like to land my patches as soon as I can,<br>
> since my clip distance work depends on them. Based on your review, I think<br>
> only two issues remain with my patch series:<br>
<br>
</div>The main issue I saw was "where do those two result helper functions<br>
live". I'd be fine with leaving them in the driver if it means the code<br>
lands sooner.<br></blockquote><div><br></div><div>Do you mean vert_result_to_frag_attrib() and frag_attrib_to_vert_result()? If so, I'm not sure what you mean by "leaving them in the driver", because I didn't put them in the driver--I put them in src/mesa/main/mtypes.h. Personally, I think that's the best place for them, because it puts them near the definitions of the enums that they translate, and it makes them available to all code that uses those enums. And there's no linker issue because the functions are both static inline. If you're ok with leaving those functions in mtypes.h, let me know and I'll push all this code tomorrow morning.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
4a727e79621b52a6dfcd5c9d5e7a7c6567a422f6 and<br>
29738bda57660b92cc55ae59fdf0259a3b9c7bc4 get my review.<br>
</blockquote></div><br><div>Awesome, thanks.</div>