On 24 October 2011 16:37, Paul Berry <span dir="ltr"><<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On 24 October 2011 15:58, Brian Paul <span dir="ltr"><<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>></span> wrote:<br></div><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On 10/24/2011 03:38 PM, Paul Berry wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This patch adds the bitfields InterpOverridesFlat,<br>
InterpOverridesSmooth, and InterpOverridesNoperspective to<br>
gl_fragment_program. These bitfields keep track of which fragment<br>
shader inputs are overridden with the GLSL "flat", "smooth", and<br>
"noperspective" interpolation qualifiers.<br>
</blockquote>
<br></div>
The names of those fields seems a little confusing to me. For example, "InterpOverridesFlat" sounds like a field that overrides flat shading with something else.<br>
<br>
How about just "InterpFlat", "InterpSmooth", etc?<br></blockquote></div><div><br>The meaning I was trying to convey with "overrides" is that bits are only set in these bitfields if the interpolation mode is overridden in GLSL. For fragment shader inputs that don't have their interpolation mode overridden, all of the bitfields have a zero. (I had to do this in order to avoid adding a bunch of code to the handling of fixed function fragment shading and ARB fragment programs). <br>
</div></div></blockquote><div><br>Another thought: how would you feel about "InterpQualifiedFlat", "InterpQualifiedSmooth", etc? That would satisfy my desire to clarify that these bits are only set when interpolation is overridden in GLSL, but without the potential for the misinterpretation you were concerned about.<br>
</div></div>