On 24 October 2011 14:16, Eric Anholt <span dir="ltr"><<a href="mailto:eric@anholt.net">eric@anholt.net</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I did do some testing by making libdrm claim a smaller aperture size<br>
and thus trigger the rollback code, which caught one bug. Generally,<br>
piglit doesn't trigger rollback at all, which is a bit concerning from<br>
a testing coverage standpoint.<br>
<br>
For people reviewing, I think the interesting part to review is mostly<br>
making sure that my assertions about the incremental changes of moving<br>
things from prepare() to emit() are true. A particular risk would be<br>
if I moved something from prepare() time (before all emit() calls) to<br>
emit() time (after some emit() calls) without noticing the dependency<br>
by those emits() in between.<br>
<br>
No noticeable performance impact from the change, though I was hoping<br>
to drop CPU usage a bit. Oh well.<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br>I don't understand enough of the code to give a reviewed-by, but I've read through all of it, and other than the comments I've already made, nothing jumped out at me as a problem.<br><br>
Acked-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>