On 14 December 2011 02:51, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> wrote: <div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="HOEnZb"><div class="h5">On 12/13/2011 03:35 PM, Paul Berry wrote: > This patch advertises support for EXT_transform_feedback on Intel Gen6 > and higher. > > Since transform feedback support is not completely finished yet, for > now we only advertise support for it when MESA_GL_VERSION_OVERRIDE is > 3.0 or greater (since transform feedback is required by GL version > 3.0). > --- > src/mesa/drivers/dri/intel/intel_extensions.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c b/src/mesa/drivers/dri/intel/intel_extensions.c > index 681f5f2..41ae29e 100644 > --- a/src/mesa/drivers/dri/intel/intel_extensions.c > +++ b/src/mesa/drivers/dri/intel/intel_extensions.c > @@ -98,10 +98,13 @@ intelInitExtensions(struct gl_context *ctx) > ctx->Extensions.OES_EGL_image = true; > #endif > > - if (intel->gen >= 6) > + if (intel->gen >= 6) { > ctx->Const.GLSLVersion = 130; > - else > + if (override_version >= 30) > + ctx->Extensions.EXT_transform_feedback = true; > + } else { > ctx->Const.GLSLVersion = 120; > + } > _mesa_override_glsl_version(ctx); > > if (intel->gen >= 5) </div></div>I'd go ahead and add a new (intel->gen >= 6) block after _mesa_override_glsl_version. That way this block can be solely for determining the GLSL version. </blockquote></div> That seems sensible. In fact, since we haven't started transform feedback work for gen7, I'll condition the new block on (intel->gen == 6 && override_version >= 30) for now, so that those of us with gen7 prototypes get less confusing output from our piglit runs. With that change, can I take this as a "reviewed-by"?