<div class="gmail_quote">On Mon, Jan 2, 2012 at 17:37, Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> - if (intel->gen == 6 || (intel->gen == 7 && override_version >= 30)) + if (intel->gen == 6 || + (intel->gen == 7 && intel->intelScreen->kernel_has_gen7_sol_reset)) ctx->Extensions.EXT_transform_feedback = true; </blockquote><div> If the kernel patch in previous series would return ... value = IS_GEN7(dev); ... the line above could be simplified to: if (intel->gen == 6 || intel->intelScreen->kernel_has_gen7_sol_reset) But on the other hand, it would work either way. The check for GEN7 in kernel looks cleaner and more logically correct to me, but in any case: Reviewed-by: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com">eugeni.dodonov@intel.com</a>> </div></div> -- Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"> </a>