On Feb 19, 2012 7:39 PM, "Tom Stellard" <<a href="mailto:tstellar@gmail.com">tstellar@gmail.com</a>> wrote: > > On Sun, Feb 19, 2012 at 10:13:48PM -0500, Matt Turner wrote: > > Hi Tom, > > > > Very happy to see this. It looks good, and I'm glad that you replaced > > two Makefiles with only a single Makefile.am. A couple of comments > > below. > > > > On Sun, Feb 19, 2012 at 10:05 PM, Tom Stellard <<a href="mailto:tstellar@gmail.com">tstellar@gmail.com</a>> wrote: > > > --- > > > <a href="http://configure.ac">configure.ac</a> | 1 + > > > src/gallium/drivers/r300/.gitignore | 5 ++ > > > src/gallium/drivers/r300/Makefile | 25 --------- > > > src/gallium/drivers/r300/Makefile.am | 38 ++++++++++++++ > > > src/gallium/drivers/r300/compiler/tests/.gitignore | 1 - > > > src/gallium/drivers/r300/compiler/tests/Makefile | 53 -------------------- > > > 6 files changed, 44 insertions(+), 79 deletions(-) > > > create mode 100644 src/gallium/drivers/r300/.gitignore > > > delete mode 100644 src/gallium/drivers/r300/Makefile > > > create mode 100644 src/gallium/drivers/r300/Makefile.am > > > delete mode 100644 src/gallium/drivers/r300/compiler/tests/.gitignore > > > delete mode 100644 src/gallium/drivers/r300/compiler/tests/Makefile > > > > > > diff --git a/<a href="http://configure.ac">configure.ac</a> b/<a href="http://configure.ac">configure.ac</a> > > > index 846b623..85da4d3 100644 > > > --- a/<a href="http://configure.ac">configure.ac</a> > > > +++ b/<a href="http://configure.ac">configure.ac</a> > > > @@ -1871,6 +1871,7 @@ if test "x$with_gallium_drivers" != x; then > > > gallium_require_llvm "Gallium R300" > > > GALLIUM_DRIVERS_DIRS="$GALLIUM_DRIVERS_DIRS r300" > > > gallium_check_st "radeon/drm" "dri-r300" "xorg-r300" "" "xvmc-r300" "vdpau-r300" "va-r300" > > > + AC_CONFIG_FILES([src/gallium/drivers/r300/Makefile]) > > > > Just add this to the existing AC_CONFIG_FILES around line 1934. > > > > I put it here so the Makefile would only be generated if the r300 driver > was actually being built. Is there any advantage to generating all the > Makefiles unconditionally? I think autoconf will fill in anything it finds in AC_CONFIG_FILES regardless. There's no real harm. -- Dan