On 22 February 2012 13:52, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org">idr@freedesktop.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="im">On 02/22/2012 01:41 PM, Paul Berry wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> From <a href="http://www.opengl.org/registry/specs/ARB/seamless_cube_map.txt" target="_blank">http://www.opengl.org/<u></u>registry/specs/ARB/seamless_<u></u>cube_map.txt</a>:<br> <br> Accepted by the<cap> parameter of Enable, Disable and IsEnabled,<br> and by the<pname> parameter of GetBooleanv, GetIntegerv, GetFloatv<br> and GetDoublev:<br> <br> TEXTURE_CUBE_MAP_SEAMLESS 0x884F<br> </blockquote> <br></div> Oops. That was my typo. You'll also have to regenerate the various files that depend on the XML definitions. I think this change should only cause changes in src/mesa/main/enums.c.<br> <br> Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com" target="_blank">ian.d.romanick@intel.com</a>></blockquote><div><br>Oops. I didn't realize that those files weren't built automatically. I'll send an updated patch.<br> <br>Is there any good reason why we don't automatically generate files like enum.c as part of the mesa build process? The comment at the top of src/mapi/glapi/gen/Makefile says "This file isn't used during a normal compilation since we don't want to require Python in order to compile Mesa." But I don't think that makes sense anymore, because Python is required to build files like src/mapi/es2api/glapi_mapi_tmp.h, as well as some files in src/glsl.<br> <br>In point of fact, it seems really strange that a file like src/mapi/es2api/glapi_mapi_tmp.h is autogenerated during the build process, but src/mesa/main/enums.c isn't, since both files are built from the same set of xml sources.<br> </div></div>