On Thu, Mar 15, 2012 at 3:11 PM, Eric Anholt <span dir="ltr"><<a href="mailto:eric@anholt.net">eric@anholt.net</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="HOEnZb"><div class="h5">On Fri, 9 Mar 2012 14:47:32 -0800, Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>> wrote:<br> > Currently intel driver doesn't allow to create a FBO with luminace texture<br> > as render target. Piglit test getteximage-luminance skips a sub test due to<br> > this restriction. Test passes as expected after applying this patch.<br> ><br> > Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br> > ---<br> > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 1 +<br> > 1 files changed, 1 insertions(+), 0 deletions(-)<br> ><br> > diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c<br> > index a3de2e3..7520219 100644<br> > --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c<br> > +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c<br> > @@ -541,6 +541,7 @@ brw_init_surface_formats(struct brw_context *brw)<br> > */<br> > brw->format_supported_as_render_target[MESA_FORMAT_S8_Z24] = true;<br> > brw->format_supported_as_render_target[MESA_FORMAT_X8_Z24] = true;<br> > + brw->format_supported_as_render_target[MESA_FORMAT_L8] = true;<br> > brw->format_supported_as_render_target[MESA_FORMAT_S8] = true;<br> > brw->format_supported_as_render_target[MESA_FORMAT_Z16] = true;<br> > brw->format_supported_as_render_target[MESA_FORMAT_Z32_FLOAT] = true;<br> <br> </div></div>I would not have expected this to work. Did you do a full piglit run?<br> </blockquote></div>Thanks for reminding. I missed the full piglit run on this patch. Just tested with getteximage-luminance.<div>Now i did the full run and seeing many failures. </div>