On 23 May 2012 11:15, Chad Versace <span dir="ltr"><<a href="mailto:chad.versace@linux.intel.com" target="_blank">chad.versace@linux.intel.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
</div><div><div class="h5">On 05/23/2012 10:22 AM, Kenneth Graunke wrote:<br>
> On 05/23/2012 07:45 AM, Paul Berry wrote:<br>
>> On 22 May 2012 13:02, Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a><br>
>> <mailto:<a href="mailto:eric@anholt.net">eric@anholt.net</a>>> wrote:<br>
>><br>
>> On Fri, 11 May 2012 11:03:50 -0700, Paul Berry<br>
>> <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a> <mailto:<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>>> wrote:<br>
>> > When executing a blorp operation on Gen7 that does not need a WM<br>
>> > program (i.e. a HiZ operation), we use 32-pixel dispatch mode because<br>
>> > it's faster. However, when executing a blorp operation that does<br>
>> need<br>
>> > a WM program, we need to use 16-pixel dispatch, because blorp WM<br>
>> > programs are compiled assuming 16-pixel dispatch.<br>
>><br>
>> I didn't think dispatch mode means anything unless you're actually<br>
>> dispatching a thread (though I could see how having no dispatch mode set<br>
>> might anger things). Basically, I'm thinking just always set 16, unless<br>
>> there is some efficiency reason I don't know of.<br>
>><br>
>><br>
>> I don't honestly know. Chad, I inherited the 32-pixel dispatch from<br>
>> your HiZ code, and assumed you did it on purpose because it was faster.<br>
>> But I didn't actually do any tests. Do you have any thoughts about this?<br>
><br>
> I recall Chad saying that not setting thread dispatch broke horribly, so since he had enable thread dispatch, he picked the widest mode.<br>
><br>
<br>
</div></div>What Ken said.<br></blockquote><div><br>Thanks, Chad. I'll send out a v2 patch that just uses 16-wide dispatch unconditionally.<br></div></div>