On 4 June 2012 13:11, Ian Romanick <<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>> wrote: <div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> From: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>> In single precision, 1.5707963 becomes <a href="tel:1.5707962513" value="+15707962513">1.5707962513</a> which is too small. However, 1.5707964 becomes <a href="tel:1.5707963705" value="+15707963705">1.5707963705</a> which is just right. The value 1.5707964 is already used in <a href="http://asin.ir" target="_blank">asin.ir</a>. NOTE: This is a candidate for stable release branches. Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>> Cc: Olivier Galibert <<a href="mailto:galibert@pobox.com">galibert@pobox.com</a>> Cc: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> </blockquote><div> Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> --- src/glsl/builtins/ir/<a href="http://acos.ir" target="_blank">acos.ir</a> | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/glsl/builtins/ir/<a href="http://acos.ir" target="_blank">acos.ir</a> b/src/glsl/builtins/ir/<a href="http://acos.ir" target="_blank">acos.ir</a> index f0078f8..8c3797e 100644 --- a/src/glsl/builtins/ir/<a href="http://acos.ir" target="_blank">acos.ir</a> +++ b/src/glsl/builtins/ir/<a href="http://acos.ir" target="_blank">acos.ir</a> @@ -4,26 +4,26 @@ (declare (in) float x)) ((declare () float s) (call asin (var_ref s) ((var_ref x))) - (return (expression float - (constant float (1.5707963)) (var_ref s))))) + (return (expression float - (constant float (1.5707964)) (var_ref s))))) (signature vec2 (parameters (declare (in) vec2 x)) ((declare () vec2 s) (call asin (var_ref s) ((var_ref x))) - (return (expression vec2 - (constant float (1.5707963)) (var_ref s))))) + (return (expression vec2 - (constant float (1.5707964)) (var_ref s))))) (signature vec3 (parameters (declare (in) vec3 x)) ((declare () vec3 s) (call asin (var_ref s) ((var_ref x))) - (return (expression vec3 - (constant float (1.5707963)) (var_ref s))))) + (return (expression vec3 - (constant float (1.5707964)) (var_ref s))))) (signature vec4 (parameters (declare (in) vec4 x)) ((declare () vec4 s) (call asin (var_ref s) ((var_ref x))) - (return (expression vec4 - (constant float (1.5707963)) (var_ref s))))) + (return (expression vec4 - (constant float (1.5707964)) (var_ref s))))) )) -- 1.7.6.5 </blockquote></div>