<html> <head> <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Hi Andy & Emeric,<br> <br> On 07.06.2012 16:29, Emeric Grange wrote: <blockquote cite="mid:CAMmP6ndn=2Gvyabg9fUukh-FDtQiF+uvJVuSezvJp-NLHh=5jg@mail.gmail.com" type="cite"><br> <div class="gmail_quote">2012/6/7 Andy Furniss <span dir="ltr"><<a moz-do-not-send="true" href="mailto:andyqos@ukfsn.org" target="_blank">andyqos@ukfsn.org</a>></span><br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="HOEnZb"> <div class="h5">Andy Furniss wrote:<br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Andy Furniss wrote:<br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Christian König wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> When the video buffer turns out to be larger than<br> requested by the application we shouldn't upload<br> or download more data into / from it original requested.<br> <br> Fixes: <a moz-do-not-send="true" href="https://bugs.freedesktop.org/show_bug.cgi?id=39309" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=39309</a><br> </blockquote> <br> Hi<br> <br> It doesn't fix decoding (for my 9600) - which that bug is mainly about.<br> </blockquote> </blockquote> </div> </div> </blockquote> </div> </blockquote> Yes, indeed. I also doesn't plan to close this bug after pushing this fix, it's just for avoiding the crash.<br> <br> <blockquote cite="mid:CAMmP6ndn=2Gvyabg9fUukh-FDtQiF+uvJVuSezvJp-NLHh=5jg@mail.gmail.com" type="cite"> <div class="gmail_quote"> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="HOEnZb"> <div class="h5"> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> It does avoid the crashing with s/w decode that r300 had because npot<br> wasn't enabled and the one case I found that mplayer would crash on r600<br> mentioned in the bug is also fixed.<br> <br> Unfortunately it's not quite right, there's an artifact on r300 s/w<br> decode = thin green lines right and bottom.<br> R600 with the patch doesn't show it as much, but 1080 stuff does have<br> one at the bottom.<br> </blockquote> <br> </blockquote> </div> </div> </blockquote> </div> </blockquote> Mhm, that is interesting. Can you start mplayer with gdb and put a breakpoint on vlVdpVideoMixerRender and then see what is provided as "video_source_rect" by the player? Or just set VDPAU_TRACE=1 and send me the output.<br> <br> <blockquote cite="mid:CAMmP6ndn=2Gvyabg9fUukh-FDtQiF+uvJVuSezvJp-NLHh=5jg@mail.gmail.com" type="cite"> <div class="gmail_quote"> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="HOEnZb"> <div class="h5"> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Playing some more - enabling npot for r300 will make it the same as r600<br> with the patch.<br> </blockquote> </div> </div> </blockquote> </div> </blockquote> Yeah, but there was some regression with NPOT+VDPAU, I can't remember what it was exactly but that was the reason we added a separate NPOT property for video in the first place.<br> <br> <blockquote cite="mid:CAMmP6ndn=2Gvyabg9fUukh-FDtQiF+uvJVuSezvJp-NLHh=5jg@mail.gmail.com" type="cite"> <div class="gmail_quote"> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="HOEnZb"> <div class="h5"> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <br> Never tried 422 -vo on r300 before, but it fails whatever combination of<br> npot/patch is used -<br> <br> VO: [vdpau] 704x576 => 704x576 Packed YUY2<br> r300: Ooops. Got unsupported format r8g8_r8b8_unorm in<br> r300_create_sampler_view_custom.<br> r300_state.c:1497:r300_create_sampler_view_custom: Assertion `hwformat<br> != ~0' failed.<br> Trace/breakpoint trap<br> </blockquote> </div> </div> </blockquote> </div> </blockquote> r300g doesn't supports that format, but I don't know why it fails with that error message, it should just gracefully tell mplayer though VDPAU that this isn't supported. Ah, wait a moment, IIRC mplayer never checked those properties....<br> <br> <blockquote cite="mid:CAMmP6ndn=2Gvyabg9fUukh-FDtQiF+uvJVuSezvJp-NLHh=5jg@mail.gmail.com" type="cite"> <div class="gmail_quote"> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="HOEnZb"> <div class="h5"> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <br> The next test may be a regression but I can't be sure - just would be<br> surprised if I didn't test HD decode as well as SD in the past.<br> <br> Anyway this is with or without patch. SD decode as before renders junk,<br> but HD is now throwing errors.<br> <br> r300: Implementation error: Render targets are too big in<br> r300_set_framebuffer_state, refusing to bind framebuffer state!<br> radeon: The kernel rejected CS, see dmesg for more information.<br> Then lots of -<br> r300: Implementation error: Render targets are too big in<br> r300_set_framebuffer_state, refusing to bind framebuffer state!<br> <br> from dmesg -<br> <br> [drm] Initialized radeon 2.15.0 20080528 for 0000:02:00.0 on minor 0<br> [drm:r100_cs_track_check] *ERROR* [drm] No buffer for z buffer !<br> [drm:radeon_cs_ib_chunk] *ERROR* Invalid command stream !<br> <br> If I enable npot -<br> <br> diff --git a/src/gallium/drivers/r300/r300_screen.c<br> b/src/gallium/drivers/r300/r300_screen.c<br> index da47fa2..758c690 100644<br> --- a/src/gallium/drivers/r300/r300_screen.c<br> +++ b/src/gallium/drivers/r300/r300_screen.c<br> @@ -325,7 +325,7 @@ static int r300_get_video_param(struct pipe_screen<br> *screen,<br> case PIPE_VIDEO_CAP_SUPPORTED:<br> return vl_profile_supported(screen, profile);<br> case PIPE_VIDEO_CAP_NPOT_TEXTURES:<br> - return 0;<br> + return 1;<br> case PIPE_VIDEO_CAP_MAX_WIDTH:<br> case PIPE_VIDEO_CAP_MAX_HEIGHT:<br> return vl_video_buffer_max_size(screen);<br> <br> Then the errors go away (it still renders junk).<br> </blockquote> </div> </div> </blockquote> </div> </blockquote> Sounds like we just hit some bandwidth limit in the combination NPOT+HD content.<br> <br> Don't know what to do about it, the basic problem is that I don't have an r3xx system any more, together with my RV670 that stopped working when my last AGP based board died.<br> <br> <blockquote cite="mid:CAMmP6ndn=2Gvyabg9fUukh-FDtQiF+uvJVuSezvJp-NLHh=5jg@mail.gmail.com" type="cite"> <div class="gmail_quote"> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="HOEnZb"> <div class="h5"> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote> I don't know how Christian handles his mail, but Vodafone are blocking my ISP's SMTP address, so this is just going to the list - unless someone else can reply all.</div> </div> </blockquote> <div><br> </div> <div>Replied all, I hope it helps.</div> <div>Emeric</div> </div> </blockquote> Thanks Emeric, otherwise I wouldn't have noticed Andys mails. The only good reason I still use this vodafone address is its good spam filter, but that sometimes is to strict. If that happens again just contact me on my AMD address (<a class="moz-txt-link-abbreviated" href="mailto:christian.koenig@amd.com">christian.koenig@amd.com</a>).<br> <br> Cheers,<br> Christian.<br> </body> </html>