On 30 October 2012 11:25, Jordan Justen <<a href="mailto:jordan.l.justen@intel.com" target="_blank">jordan.l.justen@intel.com</a>> wrote: <div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> v2: * Keep functions for various extensions still enabled in GL CORE profiles, and add the extension functions to dispatch_sanity.cpp:gl_core_functions_possible. * Cleanup glapi for ARB_geometry_shader4.xml * Disable unneeded ARB_geometry_shader4 functions and remove unimplemented ARB_geometry_shader4 functions. * Create common SetUpCtx to setup the context being tested. * No longer call _swrast_CreateContext, _tnl_CreateContext or _swsetup_CreateContext when creating the context. Patches 1-8: * Cleanups for CORE profile dispatch Patches 9-13: * Modify dispatch_sanity test for GL 3.1 CORE profile testing Follow on work still required: * Add all GL CORE functions to Mesa's XML. (See commented functions in dispatch_sanity.cpp:gl_core_functions_possible.) Jordan Justen (13): mesa api_exec: add comment regarding GetPointerv & CORE profiles mesa shaderapi: don't enable various functions for GL CORE glapi: alias FramebufferTextureARB to FramebufferTexture glapi: move include for ARB_get_program_binary.xml to gl_API.xml glapi: alias ProgramParameteriARB to ProgramParameteri mesa: disable ProgramParameteri until ARB_geometry_shader4 is supported mesa: remove unimplemented FramebufferTextureARB mesa: remove unimplemented FramebufferTextureFaceARB dispatch_sanity test: add version to function list dispatch_sanity test: pass ctx to validate_functions/nops dispatch_sanity test: allow newer functions to be set to NOP dispatch_sanity test: create common context creation function dispatch_sanity test: add GL CORE 3.1 test src/mapi/glapi/gen/ARB_geometry_shader4.xml | 4 +- src/mapi/glapi/gen/gl_API.xml | 3 + src/mapi/glapi/gen/gl_and_es_API.xml | 1 - src/mesa/main/api_exec.c | 9 +- src/mesa/main/dlist.c | 12 +- src/mesa/main/fbobject.c | 21 - src/mesa/main/fbobject.h | 9 - src/mesa/main/shaderapi.c | 4 +- src/mesa/main/tests/dispatch_sanity.cpp | 1700 +++++++++++++++++++-------- 9 files changed, 1222 insertions(+), 541 deletions(-) -- 1.7.9.5 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> I just sent out some minor comments on patches 6 and 10. The remainder are: Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>>