On 26 Nov 2012 23:53, "Johannes Obermayr" <<a href="mailto:johannesobermayr@gmx.de">johannesobermayr@gmx.de</a>> wrote: > > Am Dienstag, 20. November 2012, 12:44:48 schrieb Johannes Obermayr: > > Am Dienstag, 20. November 2012, 06:41:22 schrieb Dave Airlie: > > > > $ llvm-config --cxxflags > > > > > > > > -I/usr/include -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 > > > > -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -fPIC > > > > -fvisibility-inlines-hidden -O2 -g -D_GNU_SOURCE -Wall -W > > > > -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long > > > > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS > > > > > > And this is why we don't include LLVM CXX flags :-) > > > > > > notice the -g -O2 -Wall bits? not something that pkg-config wants in its flags. > > > > > > Dave. > > > > Does that mean the required patch does not go mainline and you want to remove LLVM_CXXFLAGS from these files: > > > > $ grep -r -n -e "LLVM_CXXFLAGS" > > configure.ac:1491:AC_SUBST([LLVM_CXXFLAGS]) > > <a href="http://configure.ac:1678">configure.ac:1678</a>: LLVM_CXXFLAGS=`$LLVM_CONFIG --cxxflags|sed -e 's/-DNDEBUG\>//g' -e 's/-pedantic//g' -e 's/-Wcovered-switch-default//g'` > > src/gallium/drivers/radeon/Makefile:13:CXXFLAGS+= $(LLVM_CXXFLAGS) > > src/gallium/drivers/r600/Makefile.am:37: $(LLVM_CXXFLAGS) > > src/gallium/auxiliary/Makefile:16:CXXFLAGS += $(LLVM_CXXFLAGS) > > configs/current.in:34:LLVM_CXXFLAGS = @LLVM_CXXFLAGS@ > > Because Dave has not answered: > Ping to get the patch pushed by somebody with permissions Well I was hoping someone would investigate... Dig in Git see where we removed these before or if we did Dave