<div dir="ltr">On 2 January 2013 10:01, Brian Paul <span dir="ltr"><<a href="mailto:brianp@vmware.com" target="_blank">brianp@vmware.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On 12/29/2012 05:35 AM, Chris Forbes wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- GL_MAX_COLOR_TEXTURE_SAMPLES<br>
- GL_MAX_DEPTH_TEXTURE_SAMPLES<br>
- GL_MAX_INTEGER_SAMPLES<br>
<br>
Signed-off-by: Chris Forbes<<a href="mailto:chrisf@ijw.co.nz" target="_blank">chrisf@ijw.co.nz</a>><br>
---<br>
src/mesa/main/get_hash_params.<u></u>py | 5 ++++-<br>
src/mesa/main/mtypes.h | 5 +++++<br>
2 files changed, 9 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/main/get_hash_<u></u>params.py b/src/mesa/main/get_hash_<u></u>params.py<br>
index 40e25e7..689a7e0 100644<br>
--- a/src/mesa/main/get_hash_<u></u>params.py<br>
+++ b/src/mesa/main/get_hash_<u></u>params.py<br>
@@ -638,9 +638,12 @@ descriptor=[<br>
[ "TEXTURE_BUFFER_FORMAT_ARB", "LOC_CUSTOM, TYPE_INT, 0, extra_texture_buffer_object" ],<br>
[ "TEXTURE_BUFFER_ARB", "LOC_CUSTOM, TYPE_INT, 0, extra_texture_buffer_object" ],<br>
<br>
-# GL_ARB_texture_multisample<br>
+# GL_ARB_texture_multisample / GL 3.2<br>
[ "TEXTURE_BINDING_2D_<u></u>MULTISAMPLE", "LOC_CUSTOM, TYPE_INT, TEXTURE_2D_MULTISAMPLE_INDEX, extra_ARB_texture_multisample" ],<br>
[ "TEXTURE_BINDING_2D_<u></u>MULTISAMPLE_ARRAY", "LOC_CUSTOM, TYPE_INT, TEXTURE_2D_MULTISAMPLE_ARRAY_<u></u>INDEX, extra_ARB_texture_multisample" ],<br>
+ [ "MAX_COLOR_TEXTURE_SAMPLES", "CONTEXT_INT(Const.<u></u>MaxColorTextureSamples), extra_ARB_texture_multisample" ],<br>
+ [ "MAX_DEPTH_TEXTURE_SAMPLES", "CONTEXT_INT(Const.<u></u>MaxDepthTextureSamples), extra_ARB_texture_multisample" ],<br>
+ [ "MAX_INTEGER_SAMPLES", "CONTEXT_INT(Const.<u></u>MaxIntegerSamples), extra_ARB_texture_multisample" ],<br>
<br>
<br>
# GL_ARB_sampler_objects / GL 3.3<br>
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h<br>
index 4be1074..6f6cdaa 100644<br>
--- a/src/mesa/main/mtypes.h<br>
+++ b/src/mesa/main/mtypes.h<br>
@@ -2970,6 +2970,11 @@ struct gl_constants<br>
* Drivers that support transform feedback must set this value to GL_FALSE.<br>
*/<br>
GLboolean DisableVaryingPacking;<br>
+<br>
+ /** GL_ARB_texture_multisample */<br>
+ GLint MaxColorTextureSamples;<br>
+ GLint MaxDepthTextureSamples;<br>
+ GLint MaxIntegerSamples;<br>
};<br>
<br>
<br>
</blockquote>
<br></div></div>
You should probably also have some code to initialize these new fields to sensible defaults in _mesa_init_constants().<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div>Agreed. It probably makes sense to initialize them to all to 1, since that's the minimum permissible value according to the spec.<br>
</div></div></div></div>