<div dir="ltr">On 11 January 2013 14:19, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The simulator gets very angry about our i2b code:<br>
<br>
<a href="http://cmp.ne" target="_blank">cmp.ne</a>(16)      g3<1>D          g2<0,1,0>D      0F<br>
<br>
We can't mix integer DWord and float types.  The only reason to use 0F<br>
here was to share code with f2b.  Split it and use 0D instead.<br></blockquote><div><br></div><div>Seems reasonable.<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 +++-<br>
 1 file changed, 3 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp<br>
index 815e421..fd07864 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp<br>
+++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp<br>
@@ -506,9 +506,11 @@ fs_visitor::visit(ir_expression *ir)<br>
       break;<br>
<br>
    case ir_unop_f2b:<br>
-   case ir_unop_i2b:<br>
       emit(CMP(this->result, op[0], fs_reg(0.0f), BRW_CONDITIONAL_NZ));<br>
       break;<br>
+   case ir_unop_i2b:<br>
+      emit(CMP(this->result, op[0], fs_reg(0), BRW_CONDITIONAL_NZ));<br>
+      break;<br>
<br>
    case ir_unop_trunc:<br>
       emit(RNDZ(this->result, op[0]));<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>