<div dir="ltr">On 21 January 2013 00:49, Chad Versace <span dir="ltr"><<a href="mailto:chad.versace@linux.intel.com" target="_blank">chad.versace@linux.intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This series lives on my gles3-glsl-packing branch.<br>
<br>
I tested this series against my piglit gles3-glsl-packing branch on Ivybridge<br>
and Sandybridge. No regressions relative to the Mesa gles3-d72ba278e.<br>
<br>
v2:<br>
- Do all of idr's minor fixes.<br>
- Improve the rounding bias in _mesa_float_to_half.<br>
- For evaluating constant pack/unpackHalf2x16 expressions, use<br>
_mesa_float_to_half/_mesa_half_to_float [for idr].<br>
- Add a bunch of new stuff to ir_builder.<br>
- Rewrite the lowering pass using ir_builder [for idr].<br>
- In lowering packHalf2x16, don't truncate subnormal float16 values to zero.<br>
And round to even rather than to zero. [for stereotype441]<br>
<br>
<br>
Chad Versace (20):<br>
glsl: Fix typo in comment<br>
glsl: Add IR lisp for GLSL ES 3.00 pack/unpack functions<br>
glsl: Extend ir_expression_operation for GLSL 3.00 pack/unpack<br>
functions (v2)<br>
glsl/standalone_scaffolding: Add stub for _mesa_warning()<br>
mesa,glsl: Move round_to_even() from glsl to mesa/main<br>
mesa: Remove rounding bias in _mesa_float_to_half()<br>
glsl: Evaluate constant GLSL ES 3.00 pack/unpack expressions (v2)<br>
glsl/ir_factory: Initialize members to NULL in constructor<br>
glsl/ir_builder: Add more helpers for constructing expressions<br>
glsl/ir_factory: Add helper method for making an ir_constant<br>
glsl/ir_builder: Add `enum writemask`<br>
glsl/ir_builder: Add helpers for making if-statements<br>
glsl: Reformat and/or/xor cases in ir_expression ctor<br>
glsl: Fix type-deduction for and/or/xor expressions<br>
glsl: Add lowering pass for GLSL ES 3.00 pack/unpack operations (v2)<br>
i965: Lower the GLSL ES 3.00 pack/unpack operations (v2)<br>
i965: Add opcodes for F32TO16 and F16TO32<br>
i965: Quote the PRM on a HorzStride subtlety<br>
i965/vs/gen7: Emit code for GLSL ES 3.00 pack/unpack operations<br>
i965/fs/gen7: Emit code for GLSL 3.00 pack/unpack operations (v2)<br></blockquote><div><br></div><div>I've already sent comments on patches 6, 7, and 15.<br><br></div><div>Patches 1-3, 5, 8-14, 16, and 18 are:<br><br>
</div><div>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br><br></div><div>Patches 4 and 17 are:<br><br>Acked-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>
<br></div><div>I'll try to look at patches 19 and 20 tomorrow morning.<br></div></div></div></div>