<div dir="ltr">On 24 January 2013 19:44, Matt Turner <span dir="ltr"><<a href="mailto:mattst88@gmail.com" target="_blank">mattst88@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Following this email are eight patches that add the 4x8 pack/unpack<br>
operations that are the difference between what GLSL ES 3.0 and<br>
ARB_shading_language_packing require.<br>
<br>
They require Chad's gles3-glsl-packing series and are available at<br>
<a href="http://cgit.freedesktop.org/~mattst88/mesa/log/?h=ARB_shading_language_packing" target="_blank">http://cgit.freedesktop.org/~mattst88/mesa/log/?h=ARB_shading_language_packing</a><br>
<br>
I've also added testing support on top of Chad's piglit patch. The<br>
{vs,fs}-unpackUnorm4x8 tests currently fail, and I've been unable to<br>
spot why.<br></blockquote><div><br></div><div>I had minor comments on patches 4/8 and 5/8.  The remainder is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>
<br></div><div>I didn't spot anything that would explain the failure in unpackUnorm4x8 tests.  I'll go have a look at your piglit tests now, and if I don't find anything there either, I'll fire up the simulator and see if I can see what's going wrong.<br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Please give it a look. I'd be nice to get this into 9.1.<br>
<br>
Thanks,<br>
Matt<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div>