<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - alloc_layout_array tx * ty assertion failure when making pbuffer current" href="https://bugs.freedesktop.org/show_bug.cgi?id=61012#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - alloc_layout_array tx * ty assertion failure when making pbuffer current" href="https://bugs.freedesktop.org/show_bug.cgi?id=61012">bug 61012</a> from <a class="email" href="mailto:sroland@vmware.com" title="Roland Scheidegger <sroland@vmware.com>"> Roland Scheidegger</a> <pre>(In reply to <a href="show_bug.cgi?id=61012#c6">comment #6</a>) > (In reply to <a href="show_bug.cgi?id=61012#c5">comment #5</a>) > > Created <a href="attachment.cgi?id=75068" name="attach_75068" title="another attempt to fix pbuffer initialization">attachment 75068</a> <a href="attachment.cgi?id=75068&action=edit" title="another attempt to fix pbuffer initialization">[details]</a> <a href='page.cgi?id=splinter.html&bug=61012&attachment=75068'>[review]</a> [review] [review] > > another attempt to fix pbuffer initialization > > > > Hmm is it legal to use XGetGeometry() with pbuffers? > > Not normally, but in the glx/xlib code we create a dummy pixmap for each > pbuffer so that we have an XID that we can pass around. Ah ok then that should be fine too. I think though in this case the function comment should be updated too (which is why I was thinking this function shouldn't really set up size for whatever reason). > > > > I think something like this patch would be better. > > That would be fine too. It's what I first tried. > > > Not sure if guarding against zero-sized buffers in drivers is needed. Might > > be but there are other instances where we hack up such windows to have > > width/height of 1 for that reason so we don't have to do it in drivers. > > I hacked up a test for a 0x0 surface. Softpipe worked but the llvmpipe > assertion failed. I guess I'd consider the llvmpipe change to be a > defensive coding check. One less way for llvmpipe to fail is good thing. Yeah probably. Though zero-sized resources are a pretty nasty thing.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>