<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jfonseca@vmware.com" title="José Fonseca <jfonseca@vmware.com>"> <span class="fn">José Fonseca</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - u_blitter only works on drivers that ignore pipe_sampler_state.normalized_coords"
href="https://bugs.freedesktop.org/show_bug.cgi?id=61091">bug 61091</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Severity</td>
<td>normal
</td>
<td>blocker
</td>
</tr>
<tr>
<td style="text-align:right;">Priority</td>
<td>medium
</td>
<td>high
</td>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>mesa-dev@lists.freedesktop.org
</td>
<td>maraeo@gmail.com
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>brianp@vmware.com, jfonseca@vmware.com, sroland@vmware.com
</td>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>piglit glsl-fs-texture2drect regression
</td>
<td>u_blitter only works on drivers that ignore pipe_sampler_state.normalized_coords
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - u_blitter only works on drivers that ignore pipe_sampler_state.normalized_coords"
href="https://bugs.freedesktop.org/show_bug.cgi?id=61091#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - u_blitter only works on drivers that ignore pipe_sampler_state.normalized_coords"
href="https://bugs.freedesktop.org/show_bug.cgi?id=61091">bug 61091</a>
from <span class="vcard"><a class="email" href="mailto:jfonseca@vmware.com" title="José Fonseca <jfonseca@vmware.com>"> <span class="fn">José Fonseca</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=61091#c1">comment #1</a>)
<span class="quote">> glBlitFramebuffer with rectangle textures is also broken with both softpipe
> and llvmpipe and it has been so for quite a while. I have a piglit test for
> that.</span >
The problem is that u_blitter is misleading drivers: it always sets
sampler_state.normalized_coords = 1, but then passes unnormalized coords for
rectangle textures.
It effectively only works on drivers that ignore normalized_coords.
If you prefer passing unnormalized coord then please fix the state.
Alternatively we could easily modify u_blitter to always pass normalized
coords.
Another thing to consider is just remove normalized_coords state, and force
drivers follow the texture target.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>