<div dir="ltr">On 12 March 2013 22:23, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 03/11/2013 03:51 PM, Paul Berry wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> This patch updates the bitfields brw_context::wm.input_size_<u></u>masks,<br> tracker::size_masks, and brw_wm_prog_key::proj_attrib_<u></u>mask, all of<br> which are indexed by gl_frag_attrib, from 32-bit to 64-bit.<br> <br> This paves the way for supporting geometry shaders, and for merging<br> the gl_frag_attrib and gl_vert_result enums. The combination of these<br> two will require at least 55 bits in the bitfields.<br> ---<br> src/mesa/drivers/dri/i965/brw_<u></u>context.h | 2 +-<br> src/mesa/drivers/dri/i965/brw_<u></u>fs.cpp | 7 ++++---<br> src/mesa/drivers/dri/i965/brw_<u></u>vs_constval.c | 18 +++++++++---------<br> src/mesa/drivers/dri/i965/brw_<u></u>wm.c | 2 +-<br> src/mesa/drivers/dri/i965/brw_<u></u>wm.h | 2 +-<br> 5 files changed, 16 insertions(+), 15 deletions(-)<br> </blockquote> <br></div> Your patch looks good. However, I hate this code, and so seeing your patch inspired me to re-measure whether the optimization is actually still worth doing. Turns out, it isn't: it actually makes performance slightly -worse- in the game it was supposed to help.<br> <br> So I've sent out a series to delete all this. Hopefully, if Eric agrees, we can just throw it out and you can drop this patch.<br> <br> Sorry for the trouble!<br> <br> --Ken<br> </blockquote></div><br></div><div class="gmail_extra" style>Oh, I would be delighted to see this go away. Earlier today I found myself wondering what effect geometry shaders are going to have on this code--it would sure be nice not to have to worry about it.</div> </div>