<div dir="ltr">On 23 March 2013 11:02, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 03/22/2013 05:42 PM, Eric Anholt wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Paul Berry <<a href="mailto:stereotype441@gmail.com" target="_blank">stereotype441@gmail.com</a>> writes:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 22 March 2013 12:32, Eric Anholt <<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Paul Berry <<a href="mailto:stereotype441@gmail.com" target="_blank">stereotype441@gmail.com</a>> writes:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
diff --git a/src/mesa/drivers/dri/i965/<u></u>brw_vs.c<br>
</blockquote>
b/src/mesa/drivers/dri/i965/<u></u>brw_vs.c<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
index c8ca018..7e941dd 100644<br>
--- a/src/mesa/drivers/dri/i965/<u></u>brw_vs.c<br>
+++ b/src/mesa/drivers/dri/i965/<u></u>brw_vs.c<br>
@@ -66,6 +66,12 @@ brw_compute_vue_map(struct brw_context *brw, struct<br>
</blockquote>
brw_vs_compile *c,<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
     vue_map->slots_valid = slots_valid;<br>
     int i;<br>
<br>
+   /* Make sure that the values we store in<br>
</blockquote>
vue_map->vert_result_to_slot and<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+    * vue_map->slot_to_vert_result won't overflow the signed chars that<br>
</blockquote>
are<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+    * used to store them.<br>
+    */<br>
+   STATIC_ASSERT(BRW_VARYING_<u></u>SLOT_MAX <= 128);<br>
</blockquote>
<br>
If the max varying slot was 128, that would be overflowed, right?<br>
<br>
</blockquote>
<br>
Actually, BRW_VARYING_SLOT_MAX is a misnomer--it's actually the max varying<br>
slot + 1.  Want me to rename it BRW_NUM_VARYING_SLOT_MAX_PLUS_<u></u>1 or<br>
something?<br>
</blockquote>
<br>
BRW_VARYING_SLOT_COUNT would be pretty good.<br>
</blockquote>
<br></div></div>
I agree, BRW_VARYING_SLOT_COUNT sounds pretty good to me.<br>
<br>
</blockquote></div><br></div><div class="gmail_extra">Ok, I'll make a follow-on patch.<br></div></div>