<div dir="ltr">Sorry that patch doesn't fix the build<div><br></div><div><div>diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp</div><div>--- a/src/gallium/state_trackers/clover/llvm/invocation.cpp 2013-03-29 12:14:25.514504748 +0000</div>
<div>+++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp 2013-03-29 12:13:03.978506530 +0000</div><div>@@ -37,7 +37,8 @@</div><div> #include <llvm/IR/DerivedTypes.h></div><div> #include <llvm/IR/LLVMContext.h></div>
<div> #include <llvm/IR/Module.h></div><div>-#include <llvm/Support/IRReader.h></div><div>+#include <llvm/Support/SourceMgr.h></div><div>+#include <llvm/IRReader/IRReader.h></div><div> #endif</div>
<div> #include <llvm/PassManager.h></div><div> #include <llvm/Support/TargetSelect.h></div></div><div><br></div><div><br></div><div style>This one does however</div><div><br></div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On 29 March 2013 11:40, Mike Lothian <span dir="ltr"><<a href="mailto:mike@fireburn.co.uk" target="_blank">mike@fireburn.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi<div><br></div><div>This include is also in src/gallium/state_trackers/clover/llvm/invocation.cpp</div><div><br></div><div><div>diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp</div>
<div>--- a/src/gallium/state_trackers/clover/llvm/invocation.cpp 2013-03-29 11:15:52.851581526 +0000</div><div>+++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp 2013-03-29 11:32:41.580559478 +0000</div>
<div>@@ -37,7 +37,6 @@</div><div> #include <llvm/IR/DerivedTypes.h></div><div> #include <llvm/IR/LLVMContext.h></div><div> #include <llvm/IR/Module.h></div><div>-#include <llvm/Support/IRReader.h></div>
<div> #endif</div><div> #include <llvm/PassManager.h></div><div> #include <llvm/Support/TargetSelect.h></div><div><br></div><div>Cheers</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Mike</div>
<div><br></div></font></span></div>
</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On 26 March 2013 12:11, Christian König <span dir="ltr"><<a href="mailto:deathsimple@vodafone.de" target="_blank">deathsimple@vodafone.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Am 26.03.2013 12:53, schrieb Michel Dänzer:<div><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Die, 2013-03-26 at 11:56 +0100, Christian König wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Christian König <<a href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>><br>
<br>
The include isn't needed and the file has moved with LLVM master.<br>
<br>
Signed-off-by: Christian König <<a href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>><br>
</blockquote>
Reviewed-by: Michel Dänzer <<a href="mailto:michel.daenzer@amd.com" target="_blank">michel.daenzer@amd.com</a>><br>
<br>
The rest of the series seems unchanged, so my review of it stands.<br>
</blockquote>
<br></div>
How about the LLVM changes? I know we could improve WQM now that it is in the backend, but I would rather like to let it stay like this for another round (as good or as bad as it is) and try to get this patchset committed first.<span><font color="#888888"><br>
<br>
Christian.</font></span><div><div><br>
______________________________<u></u>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/<u></u>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>