<div dir="ltr"><div><div>Hi Tom,<br><br>I'm not too qualified to review the llvm code changes, but the changes looked sane. I did want to point out a few piglit changes/regressions as a result of this set of patches. <br>
<br></div>For my HD6850, running latest llvm from git:<br>gegl-rgb-gamma-u8-to-ragabaf: pass -> fail<br>v3i32-stack: pass -> fail<br>v3i32-stack-array(All Tests): skip -> fail<br><br></div><div>Dumps attached for each of these tests using the following environment var:<br>
R600_DEBUG=cs,compute<br><br></div><div>Also, I did a make check in llvm, and test/CodeGen/R600/setcc.ll failed with the following... I also had this same error for the CL abs(int2) builtin, but that test had previously already been failing, so I haven't included it above. I'm assuming that we just need to expand ISD::SRA (just as we expand v2i32/v4i32 for SHL and SRL).<br>
<br>
<br><br>FAIL: LLVM :: CodeGen/R600/setcc.ll (2104 of 7693)<br>******************** TEST 'LLVM :: CodeGen/R600/setcc.ll' FAILED ********************<br>Script:<br>--<br>/home/awatry/src/llvm-build/Debug+Asserts/bin/llc < /home/awatry/src/llvm/test/CodeGen/R600/setcc.ll -march=r600 -mcpu=redwood | /home/awatry/src/llvm-build/Debug+Asserts/bin/FileCheck /home/awatry/src/llvm/test/CodeGen/R600/setcc.ll<br>
--<br>Exit Code: 2<br>Command Output (stderr):<br>--<br>LLVM ERROR: Cannot select: 0x20dce30: v2i32 = sra 0x20dd310, 0x20dcc30 [ID=26]<br> 0x20dd310: v2i32 = BUILD_VECTOR 0x20dcf30, 0x20dd210 [ID=25]<br> 0x20dcf30: i32 = shl 0x20dc830, 0x20dcb30 [ID=24]<br>
0x20dc830: i32 = select_cc 0x20d9d60, 0x20dc130, 0x20dc330, 0x20d9c60, 0x20d9b60 [ID=22]<br> 0x20d9d60: i32 = extract_vector_elt 0x20d9860, 0x20d9c60 [ID=17]<br> 0x20d9860: v2i32,ch = load 0x20a7828, 0x20d9760, 0x20d9560<LD8[undef]> [ORD=1] [ID=12]<br>
0x20d9760: i32 = Constant<40> [ORD=1] [ID=3]<br> 0x20d9560: i32 = undef [ORD=1] [ID=2]<br> 0x20d9c60: i32 = Constant<0> [ID=6]<br> 0x20dc130: i32 = extract_vector_elt 0x20d9a60, 0x20d9c60 [ID=19]<br>
0x20d9a60: v2i32,ch = load 0x20a7828, 0x20d9960, 0x20d9560<LD8[undef]> [ORD=1] [ID=13]<br> 0x20d9960: i32 = Constant<48> [ORD=1] [ID=4]<br> 0x20d9560: i32 = undef [ORD=1] [ID=2]<br>
0x20d9c60: i32 = Constant<0> [ID=6]<br> 0x20dc330: i32 = Constant<-1> [ID=7]<br> 0x20d9c60: i32 = Constant<0> [ID=6]<br> 0x20dcb30: i32 = Constant<31> [ID=9]<br> 0x20dd210: i32 = shl 0x20d9e60, 0x20dcb30 [ID=23]<br>
0x20d9e60: i32 = select_cc 0x20dc630, 0x20dc730, 0x20dc330, 0x20d9c60, 0x20d9b60 [ID=21]<br> 0x20dc630: i32 = extract_vector_elt 0x20d9860, 0x20dc530 [ID=16]<br> 0x20d9860: v2i32,ch = load 0x20a7828, 0x20d9760, 0x20d9560<LD8[undef]> [ORD=1] [ID=12]<br>
0x20d9760: i32 = Constant<40> [ORD=1] [ID=3]<br> 0x20d9560: i32 = undef [ORD=1] [ID=2]<br> 0x20dc530: i32 = Constant<1> [ID=8]<br> 0x20dc730: i32 = extract_vector_elt 0x20d9a60, 0x20dc530 [ID=18]<br>
0x20d9a60: v2i32,ch = load 0x20a7828, 0x20d9960, 0x20d9560<LD8[undef]> [ORD=1] [ID=13]<br> 0x20d9960: i32 = Constant<48> [ORD=1] [ID=4]<br> 0x20d9560: i32 = undef [ORD=1] [ID=2]<br>
0x20dc530: i32 = Constant<1> [ID=8]<br> 0x20dc330: i32 = Constant<-1> [ID=7]<br> 0x20d9c60: i32 = Constant<0> [ID=6]<br> 0x20dcb30: i32 = Constant<31> [ID=9]<br> 0x20dcc30: v2i32 = BUILD_VECTOR 0x20dcb30, 0x20dcb30 [ID=14]<br>
0x20dcb30: i32 = Constant<31> [ID=9]<br> 0x20dcb30: i32 = Constant<31> [ID=9]<br>In function: setcc_v2i32<br>FileCheck error: '-' is empty.<br>--<br><br>********************<br>Testing Time: 48.76s<br>
********************<br>Failing Tests (1):<br> LLVM :: CodeGen/R600/setcc.ll<br><br> Expected Passes : 5543<br> Expected Failures : 29<br> Unsupported Tests : 2120<br> Unexpected Failures: 1<br>make[1]: *** [check-local] Error 1<br>
make[1]: Leaving directory `/home/awatry/src/llvm-build/test'<br>make: *** [check] Error 2<br><br><br></div><div><br></div><div></div><div>--Aaron<br></div><div><br></div><div><br><br></div><div class="gmail_extra"><br>
<br><div class="gmail_quote">On Mon, Apr 29, 2013 at 3:24 PM, Tom Stellard <span dir="ltr"><<a href="mailto:tom@stellard.net" target="_blank">tom@stellard.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
The attached patchset implements a few optimizations for the bfgminer<br>
bitcoin mining program.<br>
<br>
Please Review.<br>
<span><font color="#888888"><br>
-Tom<br>
</font></span><br>_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
<br></blockquote></div><br></div></div>