<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - translate_test.c:263:10: error: too few arguments to function ‘translate[0]->run_elts’"
href="https://bugs.freedesktop.org/show_bug.cgi?id=66476">66476</a>
</td>
</tr>
<tr>
<th>Keywords</th>
<td>regression
</td>
</tr>
<tr>
<th>CC</th>
<td>zackr@vmware.com
</td>
</tr>
<tr>
<th>Assignee</th>
<td>mesa-dev@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Summary</th>
<td>translate_test.c:263:10: error: too few arguments to function ‘translate[0]->run_elts’
</td>
</tr>
<tr>
<th>Severity</th>
<td>blocker
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Reporter</th>
<td>vlee@freedesktop.org
</td>
</tr>
<tr>
<th>Hardware</th>
<td>x86-64 (AMD64)
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Version</th>
<td>git
</td>
</tr>
<tr>
<th>Component</th>
<td>Other
</td>
</tr>
<tr>
<th>Product</th>
<td>Mesa
</td>
</tr></table>
<p>
<div>
<pre>mesa: 27f2df2507a591eaf8ff6c2953fd39e60ad85482 (master)
$ scons
[...]
Compiling src/gallium/tests/unit/translate_test.c ...
src/gallium/tests/unit/translate_test.c: In function ‘main’:
src/gallium/tests/unit/translate_test.c:263:10: warning: passing argument 5 of
‘translate[0]->run_elts’ makes integer from pointer without a cast [enabled by
default]
src/gallium/tests/unit/translate_test.c:263:10: note: expected ‘unsigned int’
but argument is of type ‘unsigned char *’
src/gallium/tests/unit/translate_test.c:263:10: error: too few arguments to
function ‘translate[0]->run_elts’
src/gallium/tests/unit/translate_test.c:265:10: warning: passing argument 5 of
‘translate[1]->run_elts’ makes integer from pointer without a cast [enabled by
default]
src/gallium/tests/unit/translate_test.c:265:10: note: expected ‘unsigned int’
but argument is of type ‘unsigned char *’
src/gallium/tests/unit/translate_test.c:265:10: error: too few arguments to
function ‘translate[1]->run_elts’
src/gallium/tests/unit/translate_test.c:267:10: warning: passing argument 5 of
‘translate[0]->run_elts’ makes integer from pointer without a cast [enabled by
default]
src/gallium/tests/unit/translate_test.c:267:10: note: expected ‘unsigned int’
but argument is of type ‘unsigned char *’
src/gallium/tests/unit/translate_test.c:267:10: error: too few arguments to
function ‘translate[0]->run_elts’
src/gallium/tests/unit/translate_test.c:269:10: warning: passing argument 5 of
‘translate[1]->run_elts’ makes integer from pointer without a cast [enabled by
default]
src/gallium/tests/unit/translate_test.c:269:10: note: expected ‘unsigned int’
but argument is of type ‘unsigned char *’
src/gallium/tests/unit/translate_test.c:269:10: error: too few arguments to
function ‘translate[1]->run_elts’
1c2e5c223da28cdffe156b6b430fcdf638909021 is the first bad commit
commit 1c2e5c223da28cdffe156b6b430fcdf638909021
Author: Zack Rusin <<a href="mailto:zackr@vmware.com">zackr@vmware.com</a>>
Date: Thu Jun 27 20:40:10 2013 -0400
draw/translate: fix instancing
We were incorrectly computing the buffer offset when using the
instances. The buffer offset is always equal to:
start_instance * stride + (instance_num / instance_divisor) *
stride
We were completely ignoring the start instance quite
often producing instances that completely wrong, e.g. if
start instance = 5, instance divisor = 2, then on the first
iteration it should be:
5 * stride, not (5/2) * stride as we'd have currently, and if
start instance = 1, instance divisor = 3, then on the first
iteration it should be:
1 * stride, not 0 as we'd have.
This fixes it and adjusts all the code to the changes.
Signed-off-by: Zack Rusin <<a href="mailto:zackr@vmware.com">zackr@vmware.com</a>>
:040000 040000 cbd8d10d710bd44b366c7341c77d8a18dcd40bda
76b1ca3ea48bdb3cd7320e5a674979d77d28ab2d M src
bisect run success</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>