<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 6, 2013 at 12:31 PM, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 08/06/2013 12:10 PM, mmueller wrote:Signed-off-by: mmueller <<a href="mailto:MarkKMueller@gmail.com" target="_blank">MarkKMueller@gmail.com</a>><br>
</div><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
src/mesa/drivers/dri/i965/brw_<u></u>draw.c | 18 +++++++++---------<br>
1 file changed, 9 insertions(+), 9 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<u></u>brw_draw.c b/src/mesa/drivers/dri/i965/<u></u>brw_draw.c<br>
index 6170d07..e11d0d8 100644<br>
--- a/src/mesa/drivers/dri/i965/<u></u>brw_draw.c<br>
+++ b/src/mesa/drivers/dri/i965/<u></u>brw_draw.c<br>
@@ -367,6 +367,15 @@ static bool brw_try_draw_prims( struct gl_context *ctx,<br>
bool retval = true;<br>
GLuint i;<br>
bool fail_next = false;<br>
+ enum {<br>
+ estimated_max_prim_size =<br>
+ 512 + /* batchbuffer commands */<br>
+ ((BRW_MAX_TEX_UNIT * (sizeof(struct brw_sampler_state) + sizeof(struct gen5_sampler_default_color)))) +<br>
+ 1024 + /* gen6 VS push constants */<br>
+ 1024 + /* gen6 WM push constants */<br>
+ 512 /* misc. pad */<br>
+ };<br>
+<br>
</blockquote>
<br></div>
I think this would be better as 'const int estimated_max_prim_size = ...'. Using an enum is mostly the same (but also enforces that it's a compile-time constant), but it looks weird. :)<div class="HOEnZb"><div class="h5">
<br></div></div></blockquote><div> </div></div>OK. A new patch is on the way.... *sigh*, I knew this day was coming for the last 15 years, but I don't feel that was enough time to prepare. Now I'm forced to come out of the closet - I'm a lifelong member of PETA*.<br>
<br>All too often I clearly communicate something to the compiler yet it still goes off and does something else. Before I started using enums to replace #defines and const PODs in my code, I too thought enums were weird and ugly. After time I came to realized that it was an effective means to get the compiler to do some useful things. After a while they don't look so weird.<br>
<br></div><div class="gmail_extra">Obviously in this case it's of no concern.<br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Cheers<br><br></div><div class="gmail_extra">*PETA - Promoting Enums Through Awareness (www.PE.TA, not to be confused with People Eating Tasty Animals: PETA.org)<br>
</div></div>