<div dir="ltr">On 22 August 2013 16:08, Matt Turner <span dir="ltr"><<a href="mailto:mattst88@gmail.com" target="_blank">mattst88@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
These instructions will be used with immediate arguments in the upcoming<br>
frexp and ldexp lowering passes.<br>
---<br>
 src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 11 +++++++++++<br>
 1 file changed, 11 insertions(+)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp<br>
index 2780ab6..034ebef 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp<br>
+++ b/src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp<br>
@@ -341,9 +341,20 @@ fs_visitor::try_constant_propagate(fs_inst *inst, acp_entry *entry)<br>
          progress = true;<br>
          break;<br>
<br>
+      case BRW_OPCODE_SHL:<br>
+      case BRW_OPCODE_SHR:<br>
+         if (i == 1) {<br>
+            inst->src[i] = entry->src;<br>
+            progress = true;<br>
+         }<br>
+         break;<br>
+<br>
       case BRW_OPCODE_MACH:<br>
       case BRW_OPCODE_MUL:<br>
       case BRW_OPCODE_ADD:<br>
+      case BRW_OPCODE_OR:<br>
+      case BRW_OPCODE_AND:<br>
+      case BRW_OPCODE_XOR:<br>
          if (i == 1) {<br>
             inst->src[i] = entry->src;<br>
             progress = true;<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.3.2<br></font></span></blockquote><div><br></div><div>Shouldn't we make a similar change to brw_vec4_copy_propagation.cpp?<br></div></div></div></div>