<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - piglit ARB_uniform_buffer_object compiler layout-column_major-non-uniform regression"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=68493">68493</a>
          </td>
        </tr>

        <tr>
          <th>Keywords</th>
          <td>regression
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>idr@freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>mesa-dev@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>piglit ARB_uniform_buffer_object compiler layout-column_major-non-uniform regression
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux (All)
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>vlee@freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>x86-64 (AMD64)
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>git
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Mesa core
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>Mesa
          </td>
        </tr></table>
      <p>
        <div>
        <pre>mesa: 288a25252386d2cc372a5938fd4ff05879efd3ca (master)

piglit layout-column_major-non-uniform regressed on softpipe and llvmpipe.


$ ./bin/glslparsertest
tests/spec/arb_uniform_buffer_object/compiler/layout-column_major-non-uniform.frag
fail 1.20
Successfully compiled fragment shader
tests/spec/arb_uniform_buffer_object/compiler/layout-column_major-non-uniform.frag:
0:21(28): warning: uniform block layout qualifiers row_major and column_major
applied to non-matrix types may be rejected by older compilers

Shader source:
// [config]
// expect_result: fail
// glsl_version: 1.20
// require_extensions: GL_ARB_uniform_buffer_object
// [end config]

/* From the GL_ARB_uniform_buffer_object_spec:
 *
 *     "Uniform block layout qualifiers can be declared at global
 *      scope, on a single uniform block, or on a single block member.
 *
 *      At global scope, it is an error to use layout qualifiers to
 *      declare a variable. Instead, at global scope, layout
 *      qualifiers apply just to the keyword uniform and establish
 *      default qualification for subsequent blocks:"
 */

#version 120
#extension GL_ARB_uniform_buffer_object: require

layout(column_major) vec4 a;

vec4 foo(void) {
    return a;
}

PIGLIT: {'result': 'fail' }


dded321f92e4727584a98b71d7aaa15d4f01fb24 is the first bad commit
commit dded321f92e4727584a98b71d7aaa15d4f01fb24
Author: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>>
Date:   Thu Aug 15 11:24:11 2013 -0700

    glsl: Give a warning, not an error, for UBO qualifiers on non-matrices.

    Bugzilla: <a class="bz_bug_link 
          bz_status_VERIFIED  bz_closed"
   title="VERIFIED FIXED - [SNB/IVB/HSW Bisected]Piglit spec/ARB_uniform_buffer/object_layout-std140-base-size-and-alignment fails"
   href="show_bug.cgi?id=59648">https://bugs.freedesktop.org/show_bug.cgi?id=59648</a>
    Reviewed-by: Matt Turner <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>>
    Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>>

:040000 040000 2e6215681d169859bfba5df48f0d6bf7f8d761d3
e4792099b2f2a89ae3d09e802b97c62086ce573a M    src
bisect run success</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>