<div dir="ltr">On 29 August 2013 10:46, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 08/29/2013 10:39 AM, Paul Berry wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
On 28 August 2013 18:06, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a><br></div><div class="im">
<mailto:<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>><u></u>> wrote:<br>
<br>
    On 08/26/2013 03:12 PM, Paul Berry wrote:<br>
<br>
        ---<br></div>
           src/mesa/drivers/dri/i965/brw_<u></u>__state.h            |  8 +++<br>
           src/mesa/drivers/dri/i965/brw_<u></u>__vs_surface_state.c | 66<div class="im"><br>
        +++++++++++++++---------<br>
           2 files changed, 50 insertions(+), 24 deletions(-)<br>
<br></div>
        diff --git a/src/mesa/drivers/dri/i965/__<u></u>brw_state.h<br>
        b/src/mesa/drivers/dri/i965/__<u></u>brw_state.h<br>
        index 4814639..e7a1b40 100644<br>
        --- a/src/mesa/drivers/dri/i965/__<u></u>brw_state.h<br>
        +++ b/src/mesa/drivers/dri/i965/__<u></u>brw_state.h<div class="im"><br>
        @@ -221,6 +221,14 @@ uint32_t<br>
           get_attr_override(const struct brw_vue_map *vue_map, int<br>
        urb_entry_read_offset,<br>
                             int fs_attr, bool two_side_color, uint32_t<br>
        *max_source_attr);<br>
<br>
        +/* brw_vs_surface_state.c */<br>
        +void<br></div>
        +brw_upload_vec4_pull___<u></u>constants(struct brw_context *brw,<div class="im"><br>
        +                               GLbitfield64 brw_new_constbuf,<br>
<br>
<br>
    FWIW, brw->state.dirty.brw is only 32-bits currently.  That said,<br>
    it's probably going to change in the not-too-distant future, so<br>
    using GLbitfield64 preemptively isn't crazy.<br>
<br>
<br>
Oops, I didn't even realize I did that.  I think I'll change it back to<br>
GLbitfield, just so that it doesn't cause any confusion for people.<br>
</div></blockquote>
<br>
In that case, the next patch uses GLbitfield64 as well...<br>
<br>
--Ken<br>
</blockquote></div><br></div><div class="gmail_extra">Oh yeah, so it does.  Thanks!<br></div></div>