<div dir="ltr">On 4 September 2013 11:29, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
<br>
There is no GL_TEXTURE_CUBE_MAP_SEAMLESS in any version of OpenGL ES or<br>
in any extension that applies to OpenGL ES. The same error check<br>
already occurs for glTexParameteri.<br>
<br>
Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
Cc: Maxence Le Dore <<a href="mailto:maxence.ledore@gmail.com">maxence.ledore@gmail.com</a>><br>
---<br>
src/mesa/main/samplerobj.c | 3 ++-<br>
1 file changed, 2 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c<br>
index 39cfcd0..c3b612c 100644<br>
--- a/src/mesa/main/samplerobj.c<br>
+++ b/src/mesa/main/samplerobj.c<br>
@@ -569,7 +569,8 @@ static GLuint<br>
set_sampler_cube_map_seamless(struct gl_context *ctx,<br>
struct gl_sampler_object *samp, GLboolean param)<br>
{<br>
- if (!ctx->Extensions.AMD_seamless_cubemap_per_texture)<br>
+ if (!_mesa_is_desktop_gl(ctx)<br>
+ || !ctx->Extensions.AMD_seamless_cubemap_per_texture)<br>
return INVALID_PNAME;<br>
<br>
if (samp->CubeMapSeamless == param)<br>
<span class=""><font color="#888888">--<br>
1.8.1.4<br></font></span></blockquote><div><br></div><div>Should we add a similar check to these functions too?<br><br>- _mesa_GetSamplerParameteriv()<br>- _mesa_GetSamplerParameterfv()<br>- _mesa_GetSamplerParameterIiv()<br>
- _mesa_GetSamplerParameterIuiv()<br></div></div></div></div>