<div dir="ltr">On 10 September 2013 12:10, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br> <br> Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br> Cc: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br> ---<br> src/mesa/main/get_hash_params.py | 4 +++-<br> 1 file changed, 3 insertions(+), 1 deletion(-)<br> <br> diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py<br> index 1384134..6681123 100644<br> --- a/src/mesa/main/get_hash_params.py<br> +++ b/src/mesa/main/get_hash_params.py<br> @@ -329,9 +329,11 @@ descriptor=[<br> [ "MAJOR_VERSION", "LOC_CUSTOM, TYPE_INT, 0, extra_gl30_es3" ],<br> [ "MINOR_VERSION", "LOC_CUSTOM, TYPE_INT, 0, extra_gl30_es3" ],<br> <br> - # GL 3.0 / GLES3<br> + # GL 3.2 / GLES3<br> [ "MAX_VERTEX_OUTPUT_COMPONENTS", "CONTEXT_INT(Const.VertexProgram.MaxOutputComponents), extra_gl32_es3" ],<br> [ "MAX_FRAGMENT_INPUT_COMPONENTS", "CONTEXT_INT(Const.FragmentProgram.MaxInputComponents), extra_gl32_es3" ],<br> + [ "MAX_GEOMETRY_INPUT_COMPONENTS", "CONTEXT_INT(Const.GeometryProgram.MaxInputComponents), extra_version_32" ],<br> + [ "MAX_GEOMETRY_OUTPUT_COMPONENTS", "CONTEXT_INT(Const.GeometryProgram.MaxOutputComponents), extra_version_32" ],<br></blockquote><div><br></div><div>It troubles me to see geometry-shader-related constants under a comment that says "GLES3". Maybe make a section for "GL 3.2 / GLES3" for MAX_VERTEX_OUTPUT_COMPONENTS and MAX_FRAGMENT_INPUT_COMPONENTS and a section "GL 3.2" for MAX_GEOMETRY_{INPUT,OUTPUT}_COMPONENTS?<br> <br></div><div>Also, was the old "GL 3.0" comment just bogus? It might be worth explaining that in the commit message. It would have saved me a bunch of spec digging :)<br><br></div><div>In any case, the patch is:<br> <br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> # GL_ARB_ES3_compatibility<br> [ "MAX_ELEMENT_INDEX", "CONTEXT_INT64(Const.MaxElementIndex), extra_ARB_ES3_compatibility_api_es3"],<br> <span class="HOEnZb"><font color="#888888">--<br> 1.8.1.4<br> <br> </font></span></blockquote></div><br></div></div>