<div dir="ltr">On 15 September 2013 00:10, Francisco Jerez <span dir="ltr"><<a href="mailto:currojerez@riseup.net" target="_blank">currojerez@riseup.net</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ditto. Otherwise some of its member variables are going to have<br>
uninitialized contents in cases where its memory is not allocated<br>
using rzalloc().<br></blockquote><div><br></div><div>Nit pick: "ditto" implicitly refers to the commit message in patch 2. I'd prefer to see each commit message stand on its own, since commits often wind up getting cherry-picked into alternate orders, or viewed in isolation, so it won't always be obvious to the reader what "ditto" means.<br>
<br>With that fixed, the patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 15 +++++++++++++++<br>
1 file changed, 15 insertions(+)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp<br>
index 304636a..9770f13 100644<br>
--- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp<br>
+++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp<br>
@@ -38,7 +38,22 @@ vec4_instruction::vec4_instruction(vec4_visitor *v,<br>
this->src[0] = src0;<br>
this->src[1] = src1;<br>
this->src[2] = src2;<br>
+ this->saturate = false;<br>
+ this->force_writemask_all = false;<br>
+ this->no_dd_clear = false;<br>
+ this->no_dd_check = false;<br>
+ this->conditional_mod = BRW_CONDITIONAL_NONE;<br>
+ this->sampler = 0;<br>
+ this->texture_offset = 0;<br>
+ this->target = 0;<br>
+ this->shadow_compare = false;<br>
this->ir = v->base_ir;<br>
+ this->urb_write_flags = BRW_URB_WRITE_NO_FLAGS;<br>
+ this->header_present = false;<br>
+ this->mlen = 0;<br>
+ this->base_mrf = 0;<br>
+ this->offset = 0;<br>
+ this->ir = NULL;<br>
this->annotation = v->current_annotation;<br>
}<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.8.3.4<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>