<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [bisected] Piglit gl-3.2-draw-buffers-errors fails"
href="https://bugs.freedesktop.org/show_bug.cgi?id=69589">69589</a>
</td>
</tr>
<tr>
<th>Keywords</th>
<td>regression
</td>
</tr>
<tr>
<th>Assignee</th>
<td>mesa-dev@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Summary</th>
<td>[bisected] Piglit gl-3.2-draw-buffers-errors fails
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Reporter</th>
<td>pavel.ondracka@email.cz
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Version</th>
<td>git
</td>
</tr>
<tr>
<th>Component</th>
<td>Mesa core
</td>
</tr>
<tr>
<th>Product</th>
<td>Mesa
</td>
</tr></table>
<p>
<div>
<pre>Another older untracked piglit regression. Fails at least on i965 (GM45) and
swrast, first bad commit:
commit f3db20da1a04fd64732c62631d59aac801a1a59d
Author: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>>
Date: Fri Nov 16 14:52:01 2012 -0800
mesa: Rework crazy error code rules in glDrawBuffers().
Perhaps most importantly, this patch adds comments quoting the relevant
spec paragraphs above each error condition.
It also makes three changes:
- For FBOs, GL_COLOR_ATTACHMENTm where m >= MaxDrawBuffers is supposed
to generate INVALID_OPERATION (not INVALID_ENUM).
- Constants that refer to multiple buffers (such as FRONT, BACK, LEFT,
RIGHT, and FRONT_AND_BACK) are supposed to generate INVALID_OPERATION,
not INVALID_ENUM.
- In ES 3.0, for FBOs, buffers[i] must be NONE or GL_COLOR_ATTACHMENTi
or else INVALID_OPERATION occurs. (This is a new restriction.)
Fixes es3conform's draw-buffers-api test.
v2: The error path was missing a "return" like all the other error
paths. Also, we may as well call it glDrawBuffers in the error message
since the ARB suffix doesn't exist in ES 3.
Reviewed-by: Jordan Justen <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>>
Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>>
This wasn't probably spotted before, because at the time this was introduced,
the failing piglit test wasn't written yet. However it showed up in my recent
piglit comparison of last 5 mesa releases.
./bin/gl-3.2-draw-buffers-errors -auto -fbo
Mesa: User error: GL_INVALID_OPERATION in glDrawBuffersARB(unsupported buffer)
Mesa: User error: GL_INVALID_OPERATION in glDrawBuffersARB(unsupported buffer)
Mesa: User error: GL_INVALID_OPERATION in glDrawBuffersARB(buffer)
Expected GL_INVALID_ENUM with GL_FRONT but received: GL_INVALID_OPERATION
Mesa: User error: GL_INVALID_OPERATION in glDrawBuffersARB(buffer)
Expected GL_INVALID_ENUM with GL_BACK but received: GL_INVALID_OPERATION
Mesa: User error: GL_INVALID_OPERATION in glDrawBuffersARB(buffer)
Expected GL_INVALID_ENUM with GL_LEFT but received: GL_INVALID_OPERATION
Mesa: User error: GL_INVALID_OPERATION in glDrawBuffersARB(buffer)
Expected GL_INVALID_ENUM with GL_RIGHT but received: GL_INVALID_OPERATION
Mesa: User error: GL_INVALID_OPERATION in glDrawBuffersARB(buffer)
Expected GL_INVALID_ENUM with GL_FRONT_AND_BACK but received:
GL_INVALID_OPERATION
PIGLIT: {'result': 'fail' }</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>