<div dir="ltr">On 30 September 2013 03:08, Chris Forbes <<a href="mailto:chrisf@ijw.co.nz" target="_blank">chrisf@ijw.co.nz</a>> wrote: <div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> From: Maxence Le Dore <<a href="mailto:maxence.ledore@gmail.com">maxence.ledore@gmail.com</a>> Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> </blockquote><div> </div><div>This patch broke "make check" for me. src/mesa/main/tests/test-suite.log shows: ========================================================== Mesa 9.3.0-devel: src/mesa/main/tests/test-suite.log ========================================================== # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: main-test =============== Running main() from gtest_main.cc [==========] Running 6 tests from 2 test cases. [----------] Global test environment set-up. [----------] 2 tests from EnumStrings [ RUN ] EnumStrings.LookUpByNumber enum_strings.cpp:42: Failure Value of: _mesa_lookup_enum_by_nr(everything[i].value) Actual: "GL_MIN_PROGRAM_TEXTURE_GATHER_OFFSET_ARB" Expected: everything[i].name Which is: "GL_MIN_PROGRAM_TEXTURE_GATHER_OFFSET" enum_strings.cpp:42: Failure Value of: _mesa_lookup_enum_by_nr(everything[i].value) Actual: "GL_MAX_PROGRAM_TEXTURE_GATHER_OFFSET_ARB" Expected: everything[i].name Which is: "GL_MAX_PROGRAM_TEXTURE_GATHER_OFFSET" enum_strings.cpp:42: Failure Value of: _mesa_lookup_enum_by_nr(everything[i].value) Actual: "GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS_ARB" Expected: everything[i].name Which is: "GL_MAX_PROGRAM_TEXTURE_GATHER_COMPONENTS" [ FAILED ] EnumStrings.LookUpByNumber (0 ms) [ RUN ] EnumStrings.LookUpUnknownNumber [ OK ] EnumStrings.LookUpUnknownNumber (0 ms) [----------] 2 tests from EnumStrings (0 ms total) [----------] 4 tests from DispatchSanity_test [ RUN ] DispatchSanity_test.GL31_CORE [ OK ] DispatchSanity_test.GL31_CORE (2 ms) [ RUN ] DispatchSanity_test.GLES11 [ OK ] DispatchSanity_test.GLES11 (0 ms) [ RUN ] DispatchSanity_test.GLES2 [ OK ] DispatchSanity_test.GLES2 (1 ms) [ RUN ] DispatchSanity_test.GLES3 [ OK ] DispatchSanity_test.GLES3 (0 ms) [----------] 4 tests from DispatchSanity_test (3 ms total) [----------] Global test environment tear-down [==========] 6 tests from 2 test cases ran. (3 ms total) [ PASSED ] 5 tests. [ FAILED ] 1 test, listed below: [ FAILED ] EnumStrings.LookUpByNumber 1 FAILED TEST </div></div></div></div>