<div dir="ltr">On 11 October 2013 16:18, Eric Anholt <span dir="ltr"><<a href="mailto:eric@anholt.net" target="_blank">eric@anholt.net</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>> writes:<br>
<br>
> Despite the name, this field wasn't being set to the dispatch width at<br>
> all; it was always 8. The only place it was used was that the<br>
> constant buffer read length was aligned to it, and as far as I can<br>
> tell from the docs, there is no need to align this value to the<br>
> dispatch width; aligning it to a multiple of 8 is sufficient. So I've<br>
> just replaced it with a hardcoded 8.<br>
<br>
</div>Reviewed-by: Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a>><br>
<br>
but I'd also r-b a patch that reused brw->wm.base.push_const_size in the<br>
last hunk.<br>
</blockquote></div><br></div><div class="gmail_extra">Good idea--I like that even better.<br></div></div>