<div dir="ltr">On 27 October 2013 14:59, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Gregory Hainaut <<a href="mailto:gregory.hainaut@gmail.com">gregory.hainaut@gmail.com</a>><br>
<br>
The return value has been unused since commit d348b0c. This was<br>
originally included in another patch, but it was split out by Ian<br>
Romanick.<br>
<br>
Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
Cc: Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a>><br>
---<br>
src/mesa/main/shaderapi.c | 8 ++++----<br>
1 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c<br>
index f5c04b9..18b4f55 100644<br>
--- a/src/mesa/main/shaderapi.c<br>
+++ b/src/mesa/main/shaderapi.c<br>
@@ -926,7 +926,7 @@ _mesa_active_program(struct gl_context *ctx, struct gl_shader_program *shProg,<br>
<br>
/**<br>
*/<br>
-static bool<br>
+static void<br>
use_shader_program(struct gl_context *ctx, GLenum type,<br>
struct gl_shader_program *shProg)<br>
{<br>
@@ -955,7 +955,7 @@ use_shader_program(struct gl_context *ctx, GLenum type,<br>
}<br>
break;<br>
default:<br>
- return false;<br>
+ return;<br>
}<br>
<br>
if (*target != shProg) {<br>
@@ -982,10 +982,10 @@ use_shader_program(struct gl_context *ctx, GLenum type,<br>
}<br>
<br>
_mesa_reference_shader_program(ctx, target, shProg);<br>
- return true;<br>
+ return;<br>
}<br>
<br>
- return false;<br>
+ return;<br></blockquote><div><br></div><div>Personally, I'd just drop this final "return", since it's the end of the function.<br><br></div><div>Either way, the patch is:<br><br>Reviewed-by: Paul Berry <<a href="mailto:stereotype441@gmail.com">stereotype441@gmail.com</a>><br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
}<br>
<br>
/**<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.1.4<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>